loadSchemaDialects function #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
requested changes
Mar 7, 2024
jdesrosiers
force-pushed
the
lsp
branch
2 times, most recently
from
74ca6d0
to
c1452b8
Compare
jdesrosiers
requested changes
Mar 11, 2024
|
This PR is a mess and can't be reviewed or merged in it's current state. This is why I told you to use |
Azzam1503
force-pushed
the
get-schemas
branch
2 times, most recently
from
994fbdf
to
c2f9e1d
Compare
jdesrosiers
requested changes
Mar 13, 2024
Azzam1503
force-pushed
the
get-schemas
branch
2 times, most recently
from
bcaddc4
to
bdf76d7
Compare
jdesrosiers
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Looks good 🎉. I'll wait until to tomorrow to merge to give @HodaSalim a chance to fix the author meta-data on her commits.
Made a simple function to expose the _dialects object keys and filtering with hasDialect to make sure that we get the loaded schema dialects for json-schema LSP Project Co-authored-by: Azzam Uddin <uazzam69@gmail.com>
unix-unicorn
force-pushed
the
get-schemas
branch
from
bdf76d7
to
34f43a4
Compare
Thank you so much ! It should be updated now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a simple function to expose the _dialects object keys and filtering with hasDialect to make sure that we get the loaded schema dialects for json-schema LSP Project
Co-authored-by: Azzam Uddin uazzam69@gmail.com @Azzam1503