-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add a Metric to Track the Total of Probes Running #1222
Feat: Add a Metric to Track the Total of Probes Running #1222
Conversation
…mplemented in the child class
…ed to decrement probe running total, and config updated to reset probe running total
…unnecessary requeset and frees up resources
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
==========================================
- Coverage 63.86% 63.71% -0.16%
==========================================
Files 111 111
Lines 3277 3296 +19
Branches 561 566 +5
==========================================
+ Hits 2093 2100 +7
- Misses 998 1006 +8
- Partials 186 190 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monika Pull Request (PR)
What feature/issue does this PR add
How did you implement / how did you fix it
Added
monika_probe_running_total
metric to track the running total of Monika probes.Changed
@types/node
to version 18 for better type support.How to test
docker compose -f ./dev/prometheus/docker-compose.yaml up
.npm start -- --prometheus 3001
.http://localhost:9090/graph
.sum(monika_probe_running_total)
and click theExecute
button.Graph
tab.Demo
Graph
Abort Controller
Before
before.mp4
After
after.mp4