Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Upgrade MSW to Version 2 #1254

Merged

Conversation

haricnugraha
Copy link
Contributor

@haricnugraha haricnugraha commented Mar 15, 2024

Monika Pull Request (PR)

What feature/issue does this PR add

This pull request upgrades MSW to version 2 to leverage its latest features and improvements. It resolves #1247.

How did you implement / how did you fix it

Followed the migration guide to implement the upgrade.

How to test

Run npm test.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.72%. Comparing base (ab0f741) to head (61bb26a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files         111      111           
  Lines        3364     3364           
  Branches      590      590           
=======================================
  Hits         2110     2110           
  Misses       1064     1064           
  Partials      190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennypradipta dennypradipta merged commit f6ecb27 into hyperjumptech:main Mar 18, 2024
8 checks passed
@haricnugraha haricnugraha deleted the refactor/1247-upgrade-msw-2 branch March 18, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate tests to msw@2.x without breaking existing tests with msw@1.x via npm package alias
3 participants