Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key funder: make IGP claim threshold configurable via CLI args #4049

Closed
tkporter opened this issue Jun 25, 2024 · 0 comments · Fixed by #4074
Closed

Key funder: make IGP claim threshold configurable via CLI args #4049

tkporter opened this issue Jun 25, 2024 · 0 comments · Fixed by #4074
Assignees
@paulbalaji
Labels
aw-infra

Comments

@tkporter
Copy link
Collaborator

tkporter commented Jun 25, 2024 •
edited
Loading

Problem

Funding amounts are configurable, IGP claim thresholds aren't. This means we need to make a code change when we add a new chain to start claiming from IGPs 😔

Solution

  • Similar to what we do with desired balances, set claim thresholds via the CLI
  • Make sure we claim from newly deployed chains like linea, blast, etc

Nice to have

  • Maybe default to a claim threshold based off the relayer desired balances? Dunno
@paulbalaji paulbalaji self-assigned this Jun 26, 2024
@paulbalaji paulbalaji moved this to In Progress in Hyperlane Tasks Jun 26, 2024
@paulbalaji paulbalaji mentioned this issue Jun 28, 2024
Merged
@paulbalaji paulbalaji moved this from In Progress to In Review in Hyperlane Tasks Jun 28, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
@paulbalaji
feat(keyfunder): make IGP claim thresholds configurable via command l…
d35b546 
…ine args (#4074)

hit successor to
#3284
resolves #4049

- igp claim thresholds are moved to command line args instead, like
desired balances
	- making it easier to tweak IGP claim thresholds
- default claim threshold is 20% of desired balance for that chain
- roughly follows what I've seen with the other balance vs igp claim
thresholds
- adding thresholds for all chains we've configured a desired relayer
balance for
- drive-by fixing keyfunder logging to include the relevant metadata

testing:
- ran locally and successfully performed igp claims on
[blast](https://blastscan.io/tx/0x314d83d16e0406f77731befc7e8387dc946af01f7dc2200a426ff9748ad76d27),
[linea](https://lineascan.build/tx/0xa5f4731ebcff073dacc6c15326196002bafd9578059688fd2f29db1a2742cb14),
[viction](https://www.vicscan.xyz/tx/0x39921d3018a7b019518aa7a55a45ff29cce379bb9aabf0910c14423bd88689d5)
& more

---------

Signed-off-by: pbio <10051819+paulbalaji@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in Hyperlane Tasks Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbalaji paulbalaji

Labels
aw-infra
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
2 participants
@paulbalaji @tkporter