Configure gas overhead IGP #1588
Conversation
| ); | ||
| const interchainGasOverhead = await this.deployProxiedContract( | ||
| chain, | ||
| 'interchainGasOverhead', |
There was a problem hiding this comment.
Didn't @tkporter want to have the overhead contract to be at the existing IGP address?
There was a problem hiding this comment.
Yeah, imo this would be the smoothest transition for users
There was a problem hiding this comment.
I also wonder if we should rename the deployed overhead contract to be something like "multisigIsmIgp" and then to have the base / inner IGP be called something like "baseIgp". So that it's very clear what the use of each IGP is
There was a problem hiding this comment.
great job 🙏 really neat to see the gas benchmarks too
I'll bring this up in parking lot but I'm wondering if we should consider mailbox costs in the multisig ISM IGP or if that should live in the base IGP. If it lives in the base IGP then it makes composing IGPs much easier, but it also increases gas / complexity
| ); | ||
| const interchainGasOverhead = await this.deployProxiedContract( | ||
| chain, | ||
| 'interchainGasOverhead', |
There was a problem hiding this comment.
Yeah, imo this would be the smoothest transition for users
| ); | ||
| const interchainGasOverhead = await this.deployProxiedContract( | ||
| chain, | ||
| 'interchainGasOverhead', |
There was a problem hiding this comment.
I also wonder if we should rename the deployed overhead contract to be something like "multisigIsmIgp" and then to have the base / inner IGP be called something like "baseIgp". So that it's very clear what the use of each IGP is
yorhodes
force-pushed
the
yorhodes/multisig-ism-verify-costs
branch
from
7c4c169
to
a3a3f54
Compare
Include mailbox.process and max body in overhead
* IGP charges 1 wei * Don't pay for gas in LiquidityLayerRouter * yarn gas * Add GasOverheadIgp * Remove compiler silencing * yarn gas * Shift around some fns * nit var name * nit * Configure gas overhead IGP (#1588) * Instrument multisigIsm.verify gas costs * Add deployment tooling for IGP gas overhead * Include mailbox.process and max body in overhead * Restore multisig tests * GasOverheadIgp -> OverheadIgp, fix infra build * Prettier, change some infra / deploy tooling * run yarn hyperlane * yarn gas * yarn gas, update test contracts * rm OwnableUpgradeable for Overhead ISM * Move gas instrumentation into its own describe * back to TestRecipient__factory for normal verify tests * New submodule commits * deploy test * BaseInterchainGasPaymaster -> InterchainGasPaymaster * trying to deploy * Deploying with deployerOwnedProxyAdmin * Deployed to testnet3 * Cleaning up * cleaning up * clean * Fix tests * revert infra/package.json * clean up verification.json * Update yarn.lock * Fix lint * Changing logic around deployerOwnedProxyAdmin * Deploy mainnet * Redeploy testnet with new salt versions * nit Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
* Instrument multisigIsm.verify gas costs * Add deployment tooling for IGP gas overhead * Include mailbox.process and max body in overhead * Restore multisig tests
* IGP charges 1 wei * Don't pay for gas in LiquidityLayerRouter * Add GasOverheadIgp * Remove compiler silencing * Shift around some fns * nit var name * nit * Configure gas overhead IGP (#1588) * Instrument multisigIsm.verify gas costs * Add deployment tooling for IGP gas overhead * Include mailbox.process and max body in overhead * Restore multisig tests * GasOverheadIgp -> OverheadIgp, fix infra build * Prettier, change some infra / deploy tooling * run yarn hyperlane * yarn gas, update test contracts * rm OwnableUpgradeable for Overhead ISM * Move gas instrumentation into its own describe * back to TestRecipient__factory for normal verify tests * deploy test * BaseInterchainGasPaymaster -> InterchainGasPaymaster * trying to deploy * Deploying with deployerOwnedProxyAdmin * Deployed to testnet3 * Cleaning up * cleaning up * clean * everything * Clean up, remove more coingecko stuff * Use actual quoted value in kathy * Fix yarn lint-ts * Fix flaky test * yarn gas * Add back gas payment estimates * fix test * reset src/index.ts * revert infra/package.json * clean up verification.json * Update yarn.lock * Fix build * update kathy, some nits * Rebase had some incorrect code; fixed that * ran yarn hyperlane * update test * reset test_config.json Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Description
multisigIsm.verifygas overhead for various permutations of threshold and validator set sizeDrive-by
Related issues
Backward compatibility
Yes
Testing
Unit Tests