Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No metadata relayer support for hooks #2495

Merged
merged 12 commits into from
Jul 11, 2023

Conversation

aroralanuk
Copy link
Contributor

Description

  • Adding NoMetadataRelayer moduleType which returns an empty vec![] on MetadataBuilder::build()
  • Adding HyperlaneHookDeployer which lets you deploy the hook, ISM and a testRecipient which specifies to use the AbtractNativeISM

Drive-by changes

  • none

Related issues

Backward compatibility

Backward compatible? Yes

Tooling changes needed? Need to update node to ^18

Testing

  • Manual on testnet3

@aroralanuk aroralanuk changed the title relayer tested on testnet3 No metadata relayer support for hooks Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f7e453a). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 38754ad differs from pull request most recent head fc3a2d0. Consider uploading reports for the commit fc3a2d0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2495   +/-   ##
=======================================
  Coverage        ?   63.56%           
=======================================
  Files           ?       89           
  Lines           ?     1356           
  Branches        ?      182           
=======================================
  Hits            ?      862           
  Misses          ?      487           
  Partials        ?        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aroralanuk
Copy link
Contributor Author

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changes under /typescript/*
Mostly looks good! Just some small things :)

typescript/infra/config/environments/mainnet2/hooks.ts Outdated Show resolved Hide resolved
typescript/infra/config/environments/mainnet2/hooks.ts Outdated Show resolved Hide resolved
typescript/infra/config/environments/mainnet2/hooks.ts Outdated Show resolved Hide resolved
typescript/infra/config/environments/test/hooks.ts Outdated Show resolved Hide resolved
typescript/infra/config/environments/mainnet2/hooks.ts Outdated Show resolved Hide resolved
typescript/sdk/src/index.ts Outdated Show resolved Hide resolved
typescript/sdk/src/hook/types.ts Outdated Show resolved Hide resolved
typescript/sdk/src/hook/HyperlaneHookDeployer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/hook/HyperlaneHookDeployer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/hook/HyperlaneHookDeployer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at the rust

@aroralanuk aroralanuk requested a review from nambrot as a code owner July 11, 2023 18:03
typescript/sdk/src/hook/HyperlaneHookDeployer.ts Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
…ane-xyz/hyperlane-monorepo into kunal/no_metadata_relayer_minimal
@aroralanuk aroralanuk enabled auto-merge (squash) July 11, 2023 22:43
@aroralanuk aroralanuk merged commit d69a3f6 into main Jul 11, 2023
@aroralanuk aroralanuk deleted the kunal/no_metadata_relayer_minimal branch July 11, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants