Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana and Nautilus RC validators #2685

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

daniel-savu
Copy link
Contributor

Description

Adds addresses of the rc validator keys for solana, nautilus and their testnet counterparts

Drive-by changes

Related issues

Backward compatibility

Testing

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (76467da) 64.50% compared to head (f6622e3) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2685   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙏

I guess we should encourage this being done when a new chain is added to the hyperlane context? To avoid needing to do this as a followup when it's needed later

@daniel-savu
Copy link
Contributor Author

thanks 🙏

I guess we should encourage this being done when a new chain is added to the hyperlane context? To avoid needing to do this as a followup when it's needed later

Makes sense, but would there be a way to enforce this other than putting together some docs for adding a new chain?

@daniel-savu daniel-savu merged commit c402185 into main Aug 25, 2023
19 of 24 checks passed
@daniel-savu daniel-savu deleted the dan/solana-nautilus-rc-validators branch August 25, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants