-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust agent config parsing #2687
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
=======================================
Coverage 64.50% 64.50%
=======================================
Files 91 91
Lines 1386 1386
Branches 185 185
=======================================
Hits 894 894
Misses 485 485
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the raw config types removed, happy to merge if we go with the trait impl rather than the parse!
macro
Description
This does two things:
This PR does not cut over to the new versions just yet. That can happen once we start integrating it into the testing and deployment pipelines.
Drive-by changes
Related issues
Backward compatibility
Yes
Testing
None