Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust agent config parsing #2687

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Rust agent config parsing #2687

merged 5 commits into from
Aug 29, 2023

Conversation

mattiekat
Copy link
Contributor

Description

This does two things:

  1. It parses the agent-specific configs for the relayer, validator, and scraper.
  2. It removes the rigid structures that had been in place for parsing that were called out earlier and instead parses the serde json values directly.

This PR does not cut over to the new versions just yet. That can happen once we start integrating it into the testing and deployment pipelines.

Drive-by changes

  • Derive more was added and used where it made sense
  • The old config macro was removed

Related issues

Backward compatibility

Yes

Testing

None

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9612623) 64.50% compared to head (5a74023) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2687   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniel-savu daniel-savu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the raw config types removed, happy to merge if we go with the trait impl rather than the parse! macro

rust/agents/relayer/src/settings/mod.rs Outdated Show resolved Hide resolved
@mattiekat mattiekat enabled auto-merge (squash) August 29, 2023 23:05
@mattiekat mattiekat merged commit 17a6e79 into main Aug 29, 2023
26 checks passed
@mattiekat mattiekat deleted the mattie/config/agents branch August 29, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants