Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add data directory owned by user 1000 #2692

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: Add data directory owned by user 1000 #2692

merged 1 commit into from
Aug 29, 2023

Conversation

gbouv
Copy link
Contributor

@gbouv gbouv commented Aug 29, 2023

Description

Process user used in Dockerfile can now read and write to any volume mounted under the /data/ directory.

Drive-by changes

N/A

Related issues

Fixes: 2691

Backward compatibility

Yes

Testing

Manual

I've built the image locally and tested that we can mount any kind of docker volume under the /data/ directory

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1f4ddfa) 64.50% compared to head (0e3abde) 64.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2692   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nambrot nambrot merged commit 9612623 into hyperlane-xyz:main Aug 29, 2023
24 checks passed
@gbouv gbouv deleted the gbouv/container-data-directory branch August 29, 2023 15:50
mattiekat pushed a commit that referenced this pull request Aug 29, 2023
### Description

Process user used in Dockerfile can now read and write to any volume
mounted under the `/data/` directory.

### Drive-by changes

N/A

### Related issues

Fixes: 2691

### Backward compatibility

Yes

### Testing

Manual

I've built the image locally and tested that we can mount any kind of
docker volume under the `/data/` directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants