Fix Kathy sending from PolygonZkEvm & require MultiProtocolProvider chains to match addresses in MultiProtocolApp #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tkporter
commented
Nov 29, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3001 +/- ##
==========================================
- Coverage 67.51% 0.00% -67.52%
==========================================
Files 101 1 -100
Lines 1022 16 -1006
Branches 106 0 -106
==========================================
- Hits 690 0 -690
+ Misses 292 16 -276
+ Partials 40 0 -40
|
jmrossy
reviewed
Nov 29, 2023
jmrossy
approved these changes
Nov 30, 2023
tkporter
changed the title
tkporter
added a commit
that referenced
this pull request
Dec 1, 2023
### Description Deploy Kathy with #3001 ### Drive-by changes Small fix to deploy kathy successfully - because the relayer chains doesn't include neutron and kathy will try to create a multiprovider for all chains the env, we need to use the environment chain names as the helm `hyperlane.chains` value ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes 2 issues:
fromaddress due to this bug with PolygonZkEvm when using a non-zero value eth_estimateGas and eth_call error if a non-zero value is specified without a fundedfromaddress 0xPolygonHermez/zkevm-node#2869MultiProtocolAppto intersect the multiProvider to only work with the chains specified inaddressesDrive-by changes
n/a
Related issues
n/a
Backward compatibility
ye
Testing
Ran kathy locally successfully & sent from polygonzkevm