Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: validate data model of objects saved in a wallet. #3261

Merged

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Jun 13, 2022

Signed-off-by: Volodymyr Kubiv volodymyr.kubiv@euristiq.com

Title:
VC Wallet Data Model validation

Description:
#3260

Summary:
Data models are validated against their JSON LD context before being saved into the wallet content store.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #3261 (8c916e2) into main (3d817ac) will decrease coverage by 0.02%.
The diff coverage is 91.62%.

@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
- Coverage   88.37%   88.34%   -0.03%     
==========================================
  Files         311      311              
  Lines       42324    42384      +60     
==========================================
+ Hits        37405    37446      +41     
- Misses       3609     3626      +17     
- Partials     1310     1312       +2     
Impacted Files Coverage Δ
pkg/wallet/contents.go 98.03% <86.36%> (-0.93%) ⬇️
pkg/doc/jsonld/validate.go 90.09% <90.09%> (ø)
pkg/doc/verifiable/credential.go 91.04% <92.85%> (+0.04%) ⬆️
pkg/controller/command/vcwallet/command.go 97.19% <100.00%> (+0.02%) ⬆️
pkg/doc/util/json/json.go 78.94% <100.00%> (ø)
pkg/doc/verifiable/common.go 97.88% <100.00%> (ø)
pkg/doc/verifiable/credential_bbs.go 80.00% <100.00%> (ø)
pkg/doc/verifiable/credential_jwt.go 86.04% <100.00%> (ø)
pkg/doc/verifiable/presentation.go 86.80% <100.00%> (+0.18%) ⬆️
pkg/wallet/options.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d817ac...8c916e2. Read the comment docs.

pkg/wallet/contents.go Outdated Show resolved Hide resolved
pkg/wallet/options.go Outdated Show resolved Hide resolved
@vkubiv vkubiv force-pushed the feat-vcwallet-validate-data branch 3 times, most recently from 0722c40 to 474b517 Compare June 16, 2022 13:42
@vkubiv vkubiv force-pushed the feat-vcwallet-validate-data branch 3 times, most recently from c9e585f to cc0ab53 Compare June 16, 2022 19:52
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@vkubiv vkubiv force-pushed the feat-vcwallet-validate-data branch from cc0ab53 to 8c916e2 Compare June 17, 2022 07:55
@sudeshrshetty sudeshrshetty merged commit 82112d1 into hyperledger-archives:main Jun 17, 2022
Abdulbois pushed a commit to Abdulbois/aries-framework-go that referenced this pull request Jul 13, 2022
…archives#3261)

Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants