except ParseError: --> except ParseError as e:

[cclauss]

Make the same fix in four different files where we are catching a ParseError and then re-raising it. In the except statement, we need to capture the exception into the variable in e so that we can re-raise it in the lines immediately following. Without this change, we would raise a NameError instead of the intended exception.

Discovered via flake8 testing of https://github.com/hyperledger/sawtooth-core on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./cli/sawtooth_cli/identity.py:567:76: F821 undefined name 'e'
            raise CliException('Unable to read key in file: {}'.format(str(e)))
                                                                           ^

./cli/sawtooth_cli/sawset.py:290:76: F821 undefined name 'e'
            raise CliException('Unable to read key in file: {}'.format(str(e)))
                                                                           ^

./consensus/poet/cli/sawtooth_poet_cli/registration.py:258:76: F821 undefined name 'e'
            raise CliException('Unable to read key in file: {}'.format(str(e)))
                                                                           ^

./validator/sawtooth_validator/server/keys.py:62:67: F821 undefined name 'e'
                "Invalid key in file {}: {}".format(key_path, str(e)))
                                                                  ^

4     F821 undefined name 'e'

Signed-off-by: cclauss cclauss@bluewin.ch

[nick-drozd]

This is a known pylint bug: pylint-dev/pylint#626

[cclauss]

This is not a bug in the linting tools...

1. I did not use pylint.
2. pylint doesn't understand the scope of except clause variables pylint-dev/pylint#626 is correct. Things changed in Python 3.4 and the code will raise an UnboundLocalError in Python 3.4+

[nick-drozd]

@cclauss That was an incomplete thought on my part. What I meant was: These errors should have been caught by pylint (which runs as part of the build process), but, because of that bug, were not.