Skip to content

fabric-docs-ml #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

ODOWDAIBM
Copy link
Contributor

…abric

Signed-off-by: Anthony O'Dowd a_o-dowd@uk.ibm.com

A project to translate the Fabric documentation into Malayalam.

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy the template file to a new file called fabric-docs-ml.md instead, so that it doesn't change the template when we merge your PR.

@lehors
Copy link
Contributor

lehors commented May 14, 2020

I hereby confirm sponsorship of this lab.

@tkuhrt
Copy link
Contributor

tkuhrt commented May 14, 2020

Long term, I would like to see all of the different translation of documentation for Fabric combined under a fabric-docs folder and for all of the option to be provided under the same hyperledger-fabric.readthedocs.io location with the /en /ml /cn providing the respective translation. In the meantime, I support this lab, and I will approve once the proposal is put under labs/fabric-docs-ml.md

@vipinsun
Copy link
Contributor

So glad to see this as Malayalam is my mother tongue. It is also the longest palindrome in the OED

@lehors
Copy link
Contributor

lehors commented May 15, 2020

I had a chat with @ryjones who was asking, quite astutely I must say, why this isn't simply part of the Fabric project.

Because Fabric maintainers were uncomfortable to take ownership of something they couldn't understand they resisted bringing the Chinese translation project into Fabric. I never thought this was the right thing to do though and I think it is time this question gets looked at again. I will bring it up to the Fabric maintainers.

In the meantime I think getting the lab setup is a good first step to capitalize on the will of interested parties to get the effort going.

@ODOWDAIBM
Copy link
Contributor Author

I had a good call with Aneena, Jubilant and the Malayalam team this morning, showing the outline repo, and options for translations. @tkuhrt , to your point, I too would like to see this all incorporated under the same (i.e. Fabric) repo; as @lehors says, this is a starting point. Tracy, I think your comment is important through, as it implies using PO/POT files, which I have showed the team how to use -- the repo has been set up with the appropriate gettext/locale information.

If the repo is approved, Aneena and I will set up a RTD public build so that the Malayalam team can collaborate and have a working public doc site -- with the intention to integrate into the Fabric docs website once it reaches a level of completeness.

…abric

fabric-docs-ml

Signed-off-by: Anthony O'Dowd <a_o-dowd@uk.ibm.com>
@ODOWDAIBM
Copy link
Contributor Author

@lehors Sorry for the silly mistake Arnaud -- I moved the template to the correct directory, with the correct name. Thanks for the pointer; hopefully should be OK now.

Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@tkuhrt tkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryjones ryjones merged commit 38e3f99 into LF-Decentralized-Trust-labs:master May 15, 2020
@ryjones
Copy link
Contributor

ryjones commented May 15, 2020

@ODOWDAIBM let me know if you want a new repo, or you want to transfer the previous repo. If you want to transfer it, please transfer it to me - ryjones - or Tracy - tkuhrt - and either of us can transfer it to the hyperledger-labs org, enable DCO, and all that.

@ODOWDAIBM
Copy link
Contributor Author

Thank you @ryjones and @tkuhrt. I transferred the fabric-docs-ml repo to you Ry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants