Add multi-issuer support for wallets #46
Conversation
cmickeyb
force-pushed
the
mic.apr29.multiuser
branch
2 times, most recently
from
ddc0cd1
to
648fe45
Compare
| const int count = (int) msg.get_number("count"); | ||
| ASSERT_SUCCESS(rsp, count > 0, "invalid transfer request, invalid asset count"); | ||
|
|
||
| // if there is no issuance for this identity, we treat it as a 0 balance | ||
| ww::exchange::LedgerEntry old_entry; | ||
| ASSERT_SUCCESS(rsp, ledger_store.get_entry(old_owner, old_entry), | ||
| "transfer failed, insufficient balance for transfer"); | ||
| ASSERT_SUCCESS(rsp, count < old_entry.asset_.count_, | ||
| ASSERT_SUCCESS(rsp, count <= old_entry.asset_.count_, | ||
| "transfer failed, insufficient balance for transfer"); |
There was a problem hiding this comment.
Given that we permit transferring all "counts" of the old owner to the new owner (and thus making asset_.count = 0 for the old owner), wondering why in line 89 (as part of the issue method), we do not permit issuing "zero" counts. I would imagine this is perhaps equivalent to creating a bank account for someone with "zero balance"? I guess an independent question is "is there a notion of bank for the transfer to happen?" or can the transfer method be done on any identities?
There was a problem hiding this comment.
i'm not sure i understand the question... semantically, we assume that there is an entry for every identity though for most the balance is 0 (there is no notion of "create an account"). however, MOST 0 balance accounts are not explicitly tracked.
this specific fix allows for all funds from an account to be transferred. we don't explicitly delete the account (this is one of the cases where an account may have a 0 balance).
Refactor the contract and exchange jupyter modules into separate directory structures. This will enable more future expansion especially for application specific jupyter code for the exchange contracts. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
This completes the functionality for test 07.multiple_issuer_wallet.md. That is, a user can create a wallet that provides access to multiple issuers with functions to import new issuers, check the balance of accounts from multiple issuers, and transfer assets that reside in multiple issuers. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
* Fix a balance comparison bug * Fix a bug with self transfers Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Update the test scripts for multiuser wallets. The tests reflect the steps necessary to use the widgets interface in the wallet notebook. In addition, a new test 08.mutiple_user_wallet.md describes a test that creates two wallets and transfers assets between them. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Refresh with no services selected would generate an exception in the group selection/creation widget. This just fixes the initialization. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Expose and use the necessary interfaces for tokens to be included in wallet notebooks. The big benefit of this is that all "ownership" functions can now be handled through the same interface whether they are fungible assets (like marbles) or non-fungible assets (like tokens). Needed to support the "get_balance" method in the token contract (we already support many of the other issuer methods through tokens). Added better support for the balance and transfer in the plugins. And... most notably, added an "issuer" reference in the context file. Context references turn out to be rather useful. This creates a reference to the specific token object in the collections file. So now there is a canonical reference point for accessing issuer functions. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
cmickeyb
force-pushed
the
mic.apr29.multiuser
branch
from
648fe45
to
ea92ef7
Compare
|
With the updates to the PDO branch, this should now be complete. That is, the necessary changes to PDO are available in the submodule. |
This PR implements a multi-issuer wallet. That is, a wallet that can manage (and perform operations on) assets from multiple issuers. The wallet implements several widgets that can be used to import new issuers, check on the balance of holdings at multiple issuers (each with a unique identity), and transfer assets to other holdings (including identities with only a public key available, meaning other users running in other isolated containers).
The PR documents (or updates) three different test scenarios for the wallet:
Note that this PR does not include explicit contract flush at this point in time. That means that when refreshing the balance, it may require up to 30 seconds for the contract state to flush and be refreshed.
This should be tested with PDO PR #491 being applied: hyperledger-labs/private-data-objects#491