Add role to credential exchange records #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 72.68% 72.69% +0.01%
==========================================
Files 219 219
Lines 10136 10140 +4
==========================================
+ Hits 7367 7371 +4
Misses 2769 2769 |
Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
andrewwhitehead
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without role attached to exchange records, it is difficult to distinguish between exchanges where I am the issuer and where I am the holder as the exchange can be triggered by the holder with a proposal or by the issuer with an offer. Also relevant for down the road when a potential holder can send a credential request directly for a credential that doesn't require the full flow.