demo/Aries-Workshop.md tweak for Traction Sandbox update #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loneil
commented
Jul 30, 2024
Comment on lines
-83
to
-86
| ::: todo | ||
| To Do: Update lab to use this schema: H7W22uhD4ueQdGaGeiCgaM:2:student id:1.0.0 | ||
| ::: | ||
|
|
There was a problem hiding this comment.
Saw all schema references in this doc already using H7W22uhD4ueQdGaGeiCgaM:2:student id:1.0.0 (and used that one while testing the instructions) so I don't think this is needed?
There was a problem hiding this comment.
Sounds like it should be removed.
swcurran
approved these changes
Jul 30, 2024
|
Your call if you want to remove the todo before merging. Happy to approve again if you do. |
|
Yeah it's removed in this PR already, so could merge. |
jamshale
approved these changes
Jul 30, 2024
darshilnb
pushed a commit
to 4sure-tech/aries-cloudagent-python
that referenced
this pull request
Sep 5, 2024
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweak for state names in Tenant UI sandbox that will come with updating UI to switch to 2.0 protocols.
Remove a TODO I don't think is needed