Credentials have no easy way to access its attributes

[TimoGlastra]

Currently when you have a credential record it is not easy to access its attributes. You need to either:

• parse the preview from the offer message
• parse the raw values from the credential message
• retrieve the credential from indy storage

Aries Framework .NET just stores the attributes in the record. I think we should do the same

[jakubkoci]

I'm still curious if it's possible to utilize credentialPreview for that

[TimoGlastra]

I think that's doable. We can add a connivence method to the credential record that returns the credential preview (or something else based on the credential preview)

[jakubkoci]

My concern is security. I'm not sure if the user can rely on data in credentialPreview, because it could differ from data in actual credentialOffer/credenital.

[TimoGlastra]

Well it should be trustable. If the issuer makes an offer, the holder requests it and then issues a different credential it should throw an error and not acknowledge it.

If we don't reject that at the moment, we should add a check for it.

---

Just checked. We don't validate if the received credential matches the offer.

---

Opened #190

[jakubkoci]

Hmm. I assumed that libindy takes care of consistency between credOffer, credReq and cred, therefore we wouldn't need to validate if the received credential matches the offer. Then we just would need to validate credentialPreview against credentialOffer and store the credentialPreview as an attribute in credentialRecord

[TimoGlastra]

How to format credentials:

{
	// metadata contains credentials format specific stuff
	"metadata": {
		"credentialDefinitionId": "creddefid"
	}
	"claims": {
		"name": "name"
	}
}

I'll add a few utility methods such as returning the attributes in a properly cased or returning them alphabetically

@JamesKEbert thoughts?

[JamesKEbert]

I think as you've proposed is great. 👍