feat: New test for multi format presentation plus bug fixes #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
|
This PR contains a new test for multi format Presentation, i.e., a verification of the ability to package an indy and jsonld credential within the same proof request / presentation. Contains a couple of bug fixes in ProofServiceV2 and new method in the helper. |
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
NB-MikeRichardson
changed the title
|
I think the work in here will need to be re-submitted once the presentation-exchange branch has been merged because the code in this PR is probably going to have diverged too much, shouldn't be too much work |
TimoGlastra
deleted the branch
openwallet-foundation:feat/presentation-exchange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Richardson mike.richardson@ontario.ca