feat(core): add W3cCredentialApi

[karimStekelenburg]

This PR adds a W3cCredentialApi class with methods for storing, removing, getting, and finding credentials and credential records.

Funded by the Ontario Government

[codecov-commenter]

Codecov Report

Merging #1398 (41d1588) into main (d9cfc7d) will decrease coverage by 5.97%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   80.46%   74.49%   -5.97%     
==========================================
  Files         834      805      -29     
  Lines       19833    19064     -769     
  Branches     3198     3062     -136     
==========================================
- Hits        15958    14202    -1756     
- Misses       3867     4858     +991     
+ Partials        8        4       -4     

Impacted Files	Coverage Δ
packages/core/tests/jsonld.ts	91.66% <ø> (ø)
packages/core/src/modules/vc/W3cCredentialsApi.ts	41.17% <41.17%> (ø)
packages/core/src/agent/AgentModules.ts	100.00% <100.00%> (ø)
...ckages/core/src/modules/vc/W3cCredentialService.ts	79.41% <100.00%> (ø)
...ckages/core/src/modules/vc/W3cCredentialsModule.ts	100.00% <100.00%> (ø)
.../core/src/modules/vc/W3cCredentialsModuleConfig.ts	100.00% <100.00%> (ø)
packages/core/src/modules/vc/index.ts	100.00% <100.00%> (ø)
packages/core/src/modules/vc/models/index.ts	100.00% <100.00%> (ø)

... and 136 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[TimoGlastra]

Also, should we call it W3cCredentialsApi (plural). as we have CredentialsApi, ProofsApi, AnonCredsApi, etc..

[karimStekelenburg]

Also, should we call it W3cCredentialsApi (plural). as we have CredentialsApi, ProofsApi, AnonCreds

I noticed the service was renamed to W3cVcService, so I did the same for the API.

[TimoGlastra]

In main it's still W3cCredentialService? https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/core/src/modules/vc/W3cCredentialService.ts

I think I like W3cCredentialsApi more I think, and it aligns with the credentials module naming more maybe?

[karimStekelenburg]

In main it's still W3cCredentialService? https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/core/src/modules/vc/W3cCredentialService.ts

I think I like W3cCredentialsApi more I think, and it aligns with the credentials module naming more maybe?

Yes but it looks like you renamed the module to W3cVcModule? I don't really mind, but I do think it's nice to stay consistent across the services and modules :)

[TimoGlastra]

Ah yes, the module is called W3cVcModule. What do you prefer? I think we can change the name of the module if we want

[karimStekelenburg]

Ah yes, the module is called W3cVcModule. What do you prefer? I think we can change the name of the module if we want

Haha, this is an interesting one. I like W3cVc because it's nice and short. However, the current CredentialsModule implies that the CredentialsModule deals with non-verifiable credentials.

I'd suggest we rename everything to W3cCredentialsFoo for now and change it later if needed. That way we at least stay consistent.

Note: I do think this rename should make it plural (e.g. W3cCredentialsModule), as this is also the case for the ProofsModule and CredentialsModule.

[TimoGlastra]

It seems CI is failing.