test(indy-vdr): add delay after DID creation #1406
Conversation
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1406 +/- ##
==========================================
+ Coverage 84.90% 85.34% +0.44%
==========================================
Files 788 788
Lines 19445 19445
Branches 3162 3162
==========================================
+ Hits 16509 16595 +86
+ Misses 2929 2843 -86
Partials 7 7 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -60,5 +61,8 @@ export async function createDidOnLedger(agent: Agent, submitterDid: string) { | |||
| ) | |||
| } | |||
|
|
|||
| // Wait some time pass to let ledger settle the object | |||
| await sleep(1000) | |||
There was a problem hiding this comment.
Wouldn't it be better to see if we can resolve it? This would still make it non-deterministic albeit less.
There was a problem hiding this comment.
Could you elaborate a bit more on this suggestion? Do you mean to do a call to dids.resolve() before leaving this method?
There was a problem hiding this comment.
Yes. Resolve it on a retry or something so we know whether it for sure registered or not
There was a problem hiding this comment.
I like the idea. The sleep was an easy workaround but now that it's spread in lots of places makes sense to make a specific function for this problem.
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
In Indy VDR tests, after DID creation we are attempting to resolve the recently created DID immediately, which does not always work properly in CI. Here we add the 1000 ms delay that we also do in other Indy registrar tests.