refactor(anoncreds): master secret to link secret #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
|
Yeah the credential definition should still use |
TimoGlastra
approved these changes
Mar 31, 2023
| masterSecret?.handle.clear() | ||
| return { | ||
| linkSecretId: options?.linkSecretId ?? utils.uuid(), | ||
| linkSecretValue: LinkSecret.create(), |
There was a problem hiding this comment.
Yeah I was a really happy moment for me when I did that update :-D
|
@genaris https://github.com/hyperledger/anoncreds-rs/releases/tag/v0.1.0-dev.13 is cooking, after which we can merge this PR I think? |
|
Yes, I think we'll need to update some package.json files first so yarn.lock takes this new version. |
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
AnonCredsRsHolderServiceaccording to the recent changes in@hyperledger/anoncredsAPI and applies transformations to credential request metadata (including migration script).There is a test that is not passing, because anoncreds-rs expects the credential definition to have a
link_secretfield instead of the former/legacymaster_secretfield (this is according to this test added recently by @blu3beri).From my understanding, we should still be tied to
master_secretin this case but AnonCreds spec is not consistent about this: in section 7.2.2., it first shows an example where link_secret is used (supposed to be based in an example in Sovrin MainNet which actually uses master_secret). And then, when describing all the fields within a Credential Definition, it states: