feat: add additional formats for parsing and outputting Out Of Band Invitations #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
gmulhearn
reviewed
Aug 9, 2024
gmulhearn
reviewed
Aug 9, 2024
gmulhearn
reviewed
Aug 9, 2024
gmulhearn
reviewed
Aug 9, 2024
gmulhearn
reviewed
Aug 9, 2024
gmulhearn
reviewed
Aug 9, 2024
gmulhearn
reviewed
Aug 9, 2024
…ing test Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
gmulhearn
reviewed
Aug 18, 2024
gmulhearn
previously approved these changes
Aug 18, 2024
…y method Signed-off-by: James Ebert <jamesebert.k@gmail.com>
gmulhearn
approved these changes
Aug 22, 2024
alberto-instnt
pushed a commit
to instnt-inc/instnt-aries-vcx
that referenced
this pull request
Sep 10, 2024
…nvitations (hyperledger#1281) * feat: added invitation parsing from json, base64url, and url Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: added invitation to json, base64url, and url Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: add tests, fix minor output issues Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: added additional formats to outofbandsender, added tests Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fix formatting/clippy Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fix clippy issue Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: adjust function/method names, added no invitation padding parsing test Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fix dead code needed by testing Signed-off-by: James Ebert <jamesebert.k@gmail.com> --------- Signed-off-by: James Ebert <jamesebert.k@gmail.com>
alberto-instnt
pushed a commit
to instnt-inc/instnt-aries-vcx
that referenced
this pull request
Sep 10, 2024
…nvitations (hyperledger#1281) * feat: added invitation parsing from json, base64url, and url Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: added invitation to json, base64url, and url Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: add tests, fix minor output issues Signed-off-by: James Ebert <jamesebert.k@gmail.com> * feat: added additional formats to outofbandsender, added tests Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fix formatting/clippy Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fix clippy issue Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: adjust function/method names, added no invitation padding parsing test Signed-off-by: James Ebert <jamesebert.k@gmail.com> * chore: fix dead code needed by testing Signed-off-by: James Ebert <jamesebert.k@gmail.com> --------- Signed-off-by: James Ebert <jamesebert.k@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to parse from and output to additional formats for the
OutOfBandReceiver:Additionally, adds parsing from the same formats to the
OutOfBandSender, as new invites should always be created asInvitationorAriesMessageor with a builder. Consequently I've also removed the unusedfrom_string()method fromOutOfBandSender.Adds tests for these methods (some repetition between the files, so I can see if I can consolidate if there's too much repeated during review).
Does not include behavior for handling shortened URLs. I will create a followup GH issue for this item.