main/cli: add mordor classic testnet configuration #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Signed-off-by: soc1c <soc1c@users.noreply.github.com>
Signed-off-by: soc1c <soc1c@users.noreply.github.com>
Signed-off-by: soc1c <soc1c@users.noreply.github.com>
|
Gonna have to roll this back. It doesn't work and fails a field test. (a) Setting classic block to zero requires all blocks at zero to have the mainnet 1920000 hash. That will never happen. Probably a bug in besu code, but until that bug is sussed out we can't support mordor. |
shemnon
added a commit
to shemnon/besu
that referenced
this pull request
Nov 18, 2019
(a) Setting classic block to zero requires all blocks at zero to have the mainnet 1920000 hash. That will never happen. No clients will sync as long as this is in place (b) a full sync fails ``` 2019-11-18 10:46:51.301-07:00 | EthScheduler-Services-5 (importBlock) | WARN | MainnetBlockBodyValidator | Invalid block: state root mismatch (expected=0xb8df31366db4c4dd0076bc0ddaffdeceba6c882681108cc000db9bc5f85c300c, actual=0xf4344e62f031897ff61f9e02a465b3d13f983220f52f1e452690448dc366a2ee) ``` Probably a bug in besu code, but until that bug is sussed out we can't support mordor. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
Yes this was not ready to be merged. I should have marked this as Draft. I was waiting for @edwardmack to add the Agharta checks. Happy to revisit this. If Mordor fails, Classic would also fail. I believe it's rather an issue with the spec than the besu code. |
shemnon
added a commit
that referenced
this pull request
Nov 19, 2019
(a) Setting classic block to zero requires all blocks at zero to have the mainnet 1920000 hash. That will never happen. No clients will sync as long as this is in place (b) a full sync fails ``` 2019-11-18 10:46:51.301-07:00 | EthScheduler-Services-5 (importBlock) | WARN | MainnetBlockBodyValidator | Invalid block: state root mismatch (expected=0xb8df31366db4c4dd0076bc0ddaffdeceba6c882681108cc000db9bc5f85c300c, actual=0xf4344e62f031897ff61f9e02a465b3d13f983220f52f1e452690448dc366a2ee) ``` Probably a bug in besu code, but until that bug is sussed out we can't support mordor. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: soc1c <soc1c@users.noreply.github.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
(a) Setting classic block to zero requires all blocks at zero to have the mainnet 1920000 hash. That will never happen. No clients will sync as long as this is in place (b) a full sync fails ``` 2019-11-18 10:46:51.301-07:00 | EthScheduler-Services-5 (importBlock) | WARN | MainnetBlockBodyValidator | Invalid block: state root mismatch (expected=0xb8df31366db4c4dd0076bc0ddaffdeceba6c882681108cc000db9bc5f85c300c, actual=0xf4344e62f031897ff61f9e02a465b3d13f983220f52f1e452690448dc366a2ee) ``` Probably a bug in besu code, but until that bug is sussed out we can't support mordor. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: soc1c <soc1c@users.noreply.github.com> Signed-off-by: edwardmack <ed@edwardmack.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
(a) Setting classic block to zero requires all blocks at zero to have the mainnet 1920000 hash. That will never happen. No clients will sync as long as this is in place (b) a full sync fails ``` 2019-11-18 10:46:51.301-07:00 | EthScheduler-Services-5 (importBlock) | WARN | MainnetBlockBodyValidator | Invalid block: state root mismatch (expected=0xb8df31366db4c4dd0076bc0ddaffdeceba6c882681108cc000db9bc5f85c300c, actual=0xf4344e62f031897ff61f9e02a465b3d13f983220f52f1e452690448dc366a2ee) ``` Probably a bug in besu code, but until that bug is sussed out we can't support mordor. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds Mordor Classic Testnet support.
Fixed Issue(s)
eth-classic/mordor#3