Upgrade OpenTelemetry #3675
Merged
Upgrade OpenTelemetry #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
upgrade_otel2
branch
3 times, most recently
from
ac7f0bb
to
00debed
Compare
|
@atoulme - missing SPDX header
|
macfarla
reviewed
Apr 4, 2022
...src/test/java/org/hyperledger/besu/metrics/opentelemetry/OpenTelemetryMetricsSystemTest.java
Show resolved
Hide resolved
atoulme
force-pushed
the
upgrade_otel2
branch
2 times, most recently
from
81a9988
to
0e189f7
Compare
|
SonarCloud Quality Gate failed. |
jflo
approved these changes
Apr 27, 2022
...cs/core/src/main/java/org/hyperledger/besu/metrics/opentelemetry/MetricsOtelPushService.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/hyperledger/besu/metrics/opentelemetry/OpenTelemetryMetricsSystemTest.java
Outdated
Show resolved
Hide resolved
|
@atoulme there's still some ATs failing on this one |
|
Sorry, long time. I got back and fixed the AT locally, let's see it. |
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
Jun 29, 2022
This reverts commit 78717ad. Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
macfarla
added a commit
that referenced
this pull request
Jun 30, 2022
atoulme
added a commit
that referenced
this pull request
Nov 14, 2022
* Revert "Revert "Upgrade OpenTelemetry (#3675)" (#4031)" This reverts commit 17de636. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * Make sure we don't initialize the OpenTelemetry global singleton by mistake Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * disable global otel singleton explicitly Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * make sure to set GlobalOpenTelemetry at most once to avoid test failures Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * reset for tests Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * fix changelog Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
wcgcyx
pushed a commit
to wcgcyx/besu
that referenced
this pull request
Nov 16, 2022
* Revert "Revert "Upgrade OpenTelemetry (hyperledger#3675)" (hyperledger#4031)" This reverts commit 17de636. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * Make sure we don't initialize the OpenTelemetry global singleton by mistake Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * disable global otel singleton explicitly Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * make sure to set GlobalOpenTelemetry at most once to avoid test failures Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * reset for tests Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * fix changelog Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: wcgcyx <wcgcyx@gmail.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
* Revert "Revert "Upgrade OpenTelemetry (hyperledger#3675)" (hyperledger#4031)" This reverts commit 17de636. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * Make sure we don't initialize the OpenTelemetry global singleton by mistake Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * disable global otel singleton explicitly Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * make sure to set GlobalOpenTelemetry at most once to avoid test failures Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * reset for tests Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * fix changelog Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Upgrade OpenTelemetry Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * remove a single sleep, poll with a for loop instead Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * use the new approach to send trace requests Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
This reverts commit 78717ad. Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Revert "Revert "Upgrade OpenTelemetry (hyperledger#3675)" (hyperledger#4031)" This reverts commit 17de636. Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * Make sure we don't initialize the OpenTelemetry global singleton by mistake Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * disable global otel singleton explicitly Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * make sure to set GlobalOpenTelemetry at most once to avoid test failures Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * reset for tests Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> * fix changelog Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
PR description
Upgrades OpenTelemetry to the latest version, and make sure we configure the SDK with environment variables.
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog