Introduce RocksDbSegmentIdentifier to avoid changing the storege plug… #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
approved these changes
Apr 23, 2022
| import org.rocksdb.RocksDBException; | ||
| import org.rocksdb.TransactionDB; | ||
|
|
||
| public class RocksDbSegmentIdentifier { |
There was a problem hiding this comment.
how about RocksDbColumnFamilyIdentifier instead?
There was a problem hiding this comment.
Used SegmentedIdentifier to follow the naming used in the interface, but I do not have a strong opinion on this, so if you think RocksDbColumnFamilyIdentifier is fits better, I can rename it
| this.reference = new AtomicReference<>(columnFamilyHandle); | ||
| } | ||
|
|
||
| public void recreate() { |
There was a problem hiding this comment.
I don't think recreate implies storage is reclaimed. how about reset or clear?
…in interface Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
matkt
reviewed
Apr 25, 2022
...perledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorage.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
lucassaldanha
pushed a commit
to lucassaldanha/besu
that referenced
this pull request
May 4, 2022
hyperledger#3755) * Introduce RocksDbSegmentIdentifier to avoid changing the storege plugin interface Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
hyperledger#3755) * Introduce RocksDbSegmentIdentifier to avoid changing the storege plugin interface Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in interface
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
A refactor of #3734 to avoid changing the storage plugin interface
Fixed Issue(s)
fixes #3722
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog