Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the BlockPropagationManager when it receives the TTD reached event #3809

Merged
merged 3 commits into from
May 9, 2022

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 9, 2022

Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net

PR description

Fixed Issue(s)

fixes #3797

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@fab-10 fab-10 force-pushed the 3797-stop-block-propagation-at-ttd branch from a3f5a34 to f70a33f Compare May 9, 2022 17:44
@fab-10 fab-10 marked this pull request as ready for review May 9, 2022 17:46
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the 3797-stop-block-propagation-at-ttd branch from f70a33f to 6f7712f Compare May 9, 2022 18:01
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner approach, thanks!

@fab-10 fab-10 changed the title Stop the BlockPropagationManager when it receive the TTD reached event Stop the BlockPropagationManager when it receives the TTD reached event May 9, 2022
@jflo jflo enabled auto-merge (squash) May 9, 2022 21:50
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@jflo jflo merged commit 35fe0fe into hyperledger:main May 9, 2022
@fab-10 fab-10 deleted the 3797-stop-block-propagation-at-ttd branch May 10, 2022 08:00
@fab-10 fab-10 added the mainnet label Jun 28, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…nt (hyperledger#3809)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Co-authored-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Propagation continues after TTD was hit
2 participants