Feature/remove experimental merge flag #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarla
approved these changes
May 20, 2022
| @@ -569,8 +567,9 @@ static class GraphQlOptionGroup { | |||
| static class EngineRPCOptionGroup { | |||
| @Option( | |||
| names = {"--engine-rpc-enabled"}, | |||
| description = "Set to start the Engine JSON-RPC service (default: ${DEFAULT-VALUE})") | |||
| private final Boolean isEngineRpcEnabled = false; | |||
| description = "deprected parameter, do not use.", | |||
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| - multi-arch docker builds for amd64 and arm64 [#2954](https://github.com/hyperledger/besu/pull/2954) | |||
| - Filter Netty native lib errors likewise the pure Java implementation [#3807](https://github.com/hyperledger/besu/pull/3807) | |||
| - Add ropsten terminal total difficulty config [#3871](https://github.com/hyperledger/besu/pull/3871) | |||
| - Deprecate experimental merge flag and engine-rpc-enabled flag [#3875](https://github.com/hyperledger/besu/pull/3875) | |||
There was a problem hiding this comment.
will need to move to 22.4.2
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/remove-experimental-merge-flag
branch
from
45a41ef
to
3e69200
Compare
|
SonarCloud Quality Gate failed. |
|
Even if the flag was experimental, some users that are still referring to previous instructions are confused since Besu does not start, so probably some documentation needs to be updated as consequence of this. |
2 tasks
sharad-develop
pushed a commit
to sharad-develop/besu
that referenced
this pull request
May 27, 2022
* deprecate Xmerge-support and engine-rpc-enabled cli params Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Sharad Gulati <sharad.develop@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* deprecate Xmerge-support and engine-rpc-enabled cli params Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
removes merge specific flags and defers to genesis configuration to enable or disable merge transition and engine api
--Xmerge-support--engine-rpc-enabledFixed Issue(s)
fixed remainder of #3838
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog