-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process_release metric. #3997
Conversation
Signed-off-by: Jim McDonald <Jim@mcdee.net>
Signed-off-by: Jim McDonald <Jim@mcdee.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contrib!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics is the wrong place for this. Long term it will increase the cardinality of the measures and really isn't a metric of operation. This is more appropriate for log output, and is, in fact, already present in log outputs.
@shemnon logs aren't easily available remotely, and commonly this sort of information leaves the logs relatively quickly as they rotate or are truncated. All beacon nodes provide some form of this information in their metrics, and it has proven useful to be able to obtain information about the deployed version across multiple instances in larger operational environments. As for the cardinality, we're talking 20-30 per year and this is insignificant compared to the volume of data being gathered elsewhere. |
Its a bad devops practice. What is the measure of the gauge? The real measure is coming through a label instead of the metric itself, the metric should be what is queried, not the labels.
Can you provide concrete examples? |
It is the number of instances of the process that are running, with the label being the version. It may not seem to make so much sense when you are considering a single instance, but aggregating this metric across a larger environment provides information on the breakdown of how many instances of each version are active.
Lighthouse:
Nimbus:
Prysm:
Teku:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this has become an industry standard I'll remove my block.
But I will leave my non-blocking objection that this is an abuse of metrics.
* Add process_info metric. Signed-off-by: Jim McDonald <Jim@mcdee.net> * Updated changelog with version metric. Signed-off-by: Jim McDonald <Jim@mcdee.net>
PR description
Add a
process_release
metric containing release information. This shows up as following:Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog