[Issue-3867] Limit outbound eth message sizes #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
macfarla
approved these changes
Jul 4, 2022
|
|
||
| assertThat(ethMessages.dispatch(new EthMessage(ethPeer, GetNodeDataMessage.create(hashes)))) | ||
| .contains(NodeDataMessage.create(expectedResult)); | ||
| } |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Meredith Baxter <meredith.baxter@palm.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Builds on #4002.
Add logic to limit the size of outbound
ethsubprotocol messages:This should prevent nodes from being disconnected from their peers for sending messages that exceed the 10MB limit.
Fixed Issue(s)
Fixes #3867
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog