Finalised blocks should not prevent reorgs in BWS #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bug in the logic in the check prevented BWSync to finish even in some valid scenarios. I think it is better to remove it altogether. |
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
gezero
force-pushed
the
bws-should-ignore-finalised
branch
from
a077665
to
44d3d7a
Compare
garyschulte
approved these changes
Jul 13, 2022
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com> Signed-off-by: Cody Born <codyborn@outlook.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Jiri Peinlich <jiri.peinlich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow reorgs bellow finalized blocks during Backwards Sync.