Remove hash to append from the queue only if the step succeeds #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
retry-execute-sync-step
branch
from
8ef8faf
to
e6ecba4
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
approved these changes
Jul 14, 2022
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
…ledger#4105) * Remove hash to append from the queue only if the step succeeds Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
…ledger#4105) * Remove hash to append from the queue only if the step succeeds Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Cody Born <codyborn@outlook.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ledger#4105) * Remove hash to append from the queue only if the step succeeds Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
In case of an error the first hash to fetch is lost, and then the backward sync tries to go ahead and start a forward sync.
Sample log
first-hash-not-retry.txt
This PR remove the hash from the queue only when its successfully fetched
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog