Fix for NoSuchElementException for missing invalid reason when rejecting a local sent transaction #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
changed the title
fab-10
force-pushed
the
txpool-add-invalid-reason
branch
from
ab210ef
to
71c6df6
Compare
2 tasks
garyschulte
approved these changes
Oct 29, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
…ledger#4569) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…ledger#4569) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Recently added entries to the
TransactionAddedStatusenum are missing the invalid reason, and this could causeNoSuchElementExceptionwhen trying to add a local transaction is rejected with one of these enum values.Adding the missing invalid reason and for the future log and return an
INTERNAL_ERRORin case invalid reason is missing, instead of throwing the exception.Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog