Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warm Coinbase (EIP-3651) #4620

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Nov 7, 2022

PR description

Add a flag to MainnetTransactionProcessor to add the miningBeneficiary to the list of pre-warmed addresses.
Have shandong fork set this flag to true by default.

Signed-off-by: Danno Ferrin danno.ferrin@swirldslabs.com

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Add a flag to MainnetTransactionProcessor to add the miningBeneficiary
to the list of pre-warmed addresses.
Have shandong fork set this flag to true by default.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon shemnon requested a review from diega November 7, 2022 16:19
@shemnon
Copy link
Contributor Author

shemnon commented Nov 7, 2022

No changelog. Once shandong syncs or shanghai fork locks down it becomes changelog worthy.

@@ -80,7 +84,7 @@

public static ProtocolSpecBuilder dieHardDefinition(
final Optional<BigInteger> chainId,
final OptionalInt configContractSizeLimit,
final OptionalInt ignoredConfigContractSizeLimit,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'ignoredConfigContractSizeLimit' is never used.
public TransactionProcessingResult processTransaction(
final Blockchain blockchain,
final Blockchain ignoredBlockchain,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'ignoredBlockchain' is never used.
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemnon shemnon enabled auto-merge (squash) November 8, 2022 17:03
@shemnon shemnon merged commit 1f78249 into hyperledger:main Nov 8, 2022
macfarla pushed a commit to jflo/besu that referenced this pull request Jan 10, 2023
Add a flag to MainnetTransactionProcessor to add the miningBeneficiary
to the list of pre-warmed addresses.
Have shandong fork set this flag to true by default.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Add a flag to MainnetTransactionProcessor to add the miningBeneficiary
to the list of pre-warmed addresses.
Have shandong fork set this flag to true by default.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants