-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warm Coinbase (EIP-3651) #4620
Warm Coinbase (EIP-3651) #4620
Conversation
Add a flag to MainnetTransactionProcessor to add the miningBeneficiary to the list of pre-warmed addresses. Have shandong fork set this flag to true by default. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
No changelog. Once shandong syncs or shanghai fork locks down it becomes changelog worthy. |
@@ -80,7 +84,7 @@ | |||
|
|||
public static ProtocolSpecBuilder dieHardDefinition( | |||
final Optional<BigInteger> chainId, | |||
final OptionalInt configContractSizeLimit, | |||
final OptionalInt ignoredConfigContractSizeLimit, |
Check notice
Code scanning / CodeQL
Useless parameter
public TransactionProcessingResult processTransaction( | ||
final Blockchain blockchain, | ||
final Blockchain ignoredBlockchain, |
Check notice
Code scanning / CodeQL
Useless parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a flag to MainnetTransactionProcessor to add the miningBeneficiary to the list of pre-warmed addresses. Have shandong fork set this flag to true by default. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Add a flag to MainnetTransactionProcessor to add the miningBeneficiary to the list of pre-warmed addresses. Have shandong fork set this flag to true by default. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
PR description
Add a flag to MainnetTransactionProcessor to add the miningBeneficiary to the list of pre-warmed addresses.
Have shandong fork set this flag to true by default.
Signed-off-by: Danno Ferrin danno.ferrin@swirldslabs.com
Fixed Issue(s)
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog