Optimize performance of WorldStateUpdater commit method #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahamlat
changed the title
ahamlat
changed the title
…allel Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
ahamlat
force-pushed
the
optimize-worldstateupdater-commit-method
branch
from
2d9032c
to
c40778a
Compare
ahamlat
changed the title
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
shemnon
approved these changes
Nov 10, 2022
shemnon
reviewed
Nov 10, 2022
garyschulte
approved these changes
Nov 10, 2022
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/bonsai/BonsaiWorldStateUpdater.java
Show resolved
Hide resolved
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…e loops, that may cause database corruption Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
wcgcyx
pushed a commit
to wcgcyx/besu
that referenced
this pull request
Nov 16, 2022
…4635) WorldStateUpdater commit method is one of the most consuming methods during block processing (engine_newPayloadV1 call). This PR will focus on parallelizing some parts of this method to make it faster. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: wcgcyx <wcgcyx@gmail.com>
macfarla
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
…4635) WorldStateUpdater commit method is one of the most consuming methods during block processing (engine_newPayloadV1 call). This PR will focus on parallelizing some parts of this method to make it faster. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…4635) WorldStateUpdater commit method is one of the most consuming methods during block processing (engine_newPayloadV1 call). This PR will focus on parallelizing some parts of this method to make it faster. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ameziane H ameziane.hamlat@consensys.net
Co-authored-by: Karim TAAM karim.t2am@gmail.com
PR description
WorldStateUpdater commit method is one of the most consuming methods during block processing (engine_newPayloadV1 call). This PR will focus on parallelizing some parts of this method to make it faster.
The first results after 2 hours of execution
The results after 12 hours
We can see with CPU profiling that the commit methods takes less time and most of the execution is done in parallel in ForkjoinPool.commonPool().
Fixed Issue(s)
Mitigate #4549
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog