Backward sync: use retry switching peer when fetching data from peers #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
garyschulte
force-pushed
the
bwsync-retry-switching-peer
branch
from
5ebd45f
to
e8190d1
Compare
macfarla
approved these changes
Nov 14, 2022
| peerResult -> { | ||
| debugLambda( | ||
| LOG, | ||
| "Got {} blocks {} from peer {}, attempt {}", |
There was a problem hiding this comment.
don't need the {} after blocks
| this::getAssignedPeer, | ||
| this::getRetryCount); | ||
| } else { | ||
| LOG.debug("Failed to get {} blocks after {} retries", headers.size(), getRetryCount()); |
There was a problem hiding this comment.
should the peer be logged here too
There was a problem hiding this comment.
This is the case when all peers have failed, for this the peer is not logged
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
…into bwsync-retry-switching-peer
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
2 tasks
# Conflicts: # CHANGELOG.md # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncContext.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncStep.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/ForwardSyncStep.java
jflo
approved these changes
Nov 15, 2022
wcgcyx
pushed a commit
to wcgcyx/besu
that referenced
this pull request
Nov 16, 2022
…hyperledger#4656) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: wcgcyx <wcgcyx@gmail.com>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
…hyperledger#4656) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…hyperledger#4656) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR is built on top of #4655, so please che it first.
Wait for at least one connected peer before starting the backwward sync, and use the retry mechanism that switches peer everytime it needs to retry to get data from peers, this helps reducing errors like the following ones, and makes the sync faster
Fixed Issue(s)
relates to #4446
fixes: #4698
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog