Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden option to enforce maximum or minimum eth capability #4752

Merged
merged 40 commits into from
Dec 9, 2022
Merged

Hidden option to enforce maximum or minimum eth capability #4752

merged 40 commits into from
Dec 9, 2022

Conversation

Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented Nov 30, 2022 •
edited

PR description

Create hidden flags to enforce a range of Eth capabilities. With future versions of the protocol being implemented, we may need an easy way to compare capabilities without having to change the code every time. Another use case would be to downgrade your node if an issue was found with a later protocol version.

This PR implements:

  • Flag --Xeth-capability-max that enforces a maximum capability for the Eth protocol. Use: --Xeth-capability-max=67
  • Flag --Xeth-capability-min that enforces a minimum capability for the Eth protocol. Use: --Xeth-capability-min=65

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review November 30, 2022 05:11
macfarla
macfarla reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense - another use case would be to downgrade your node if an issue was found with a later protocol version, right?

@Gabriel-Trintinalia
Copy link
Contributor Author

I think it makes sense - another use case would be to downgrade your node if an issue was found with a later protocol version, right?

That is another good example

@macfarla macfarla requested a review from matkt December 1, 2022 02:39
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as draft December 1, 2022 03:21
gfukushima and others added 24 commits December 8, 2022 14:32
@gfukushima @Gabriel-Trintinalia
Removing deprecated method (hyperledger#4741)
0be1053 
* Replace deprecated method
* Ignore field

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@macfarla @Gabriel-Trintinalia
update tuweni (hyperledger#4749)
9ef7c8f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Create hidden flag to force an eth capability maximum
8c31e7d 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Remove enabled from the name of the flag
a1deb43 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Rename flag name
2ceba5d 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@shemnon @Gabriel-Trintinalia
Mul speedup (hyperledger#4756)
5b27296 
Move mul from UInt256 wrapping to direct BigInteger math.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Add hidden option to explicitly choose the Eth capabilities
cf0fee8 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Add default variable and fix missing fromConfig
441fc9c 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Add blank line
bba963b 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Fix default values and unit tests
1a83d3b 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Fix formatting
023718f 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Possible optimization (hyperledger#4701)
925d00d 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@fab-10 @Gabriel-Trintinalia
Transaction pool price validation improvements and fixes (hyperledger…
d8702c1 
…#4598)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@matkt @ahamlat @Gabriel-Trintinalia
Preload state trie node (hyperledger#4737)
843ffff 
The idea behind this commit is to preload asynchronously account nodes and storage nodes from the database during the transaction processing to use these nodes during the calculate root hash step.
We've created two caches, one for account nodes and one for storage nodes. The size of these caches is 100k for accounts and 200k for storage. We've tested other values but this configuration is the one that works better.
We also use exporter cache metrics as Prometheus metrics to check cache efficiency.

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

Co-authored-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@diega @lukelee-sl @Gabriel-Trintinalia
[Shandong] EIP-3860 support (hyperledger#4726)
3e82b78 
* Add Shandong gas calculator to support EIP-3860

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com>

* add unit tests for Shandong gas calculator

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Co-authored-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@garyschulte @Gabriel-Trintinalia
22.10.1 release (hyperledger#4761)
0470a59 
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@garyschulte @Gabriel-Trintinalia
Prepare for version 22.10.2-SNAPSHOT (hyperledger#4762)
a703093 
* Update version to 22.10.2-SNAPSHOT
* add download links

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@siladu @macfarla @Gabriel-Trintinalia
Add log to show when we've found a peer on a matching chain id (hyper…
b76e3b0 
…ledger#4751)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@siladu @macfarla @Gabriel-Trintinalia
Print the rpc params as serialized json to make it easier to copy-pas…
beeb20d 
…te requests when debugging (hyperledger#4753)

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@jtraglia @macfarla @Gabriel-Trintinalia
Use value comparisons instead of reference comparisons in some places (…
5ac732d 
…hyperledger#4757)

Signed-off-by: Justin Traglia <jtraglia@pm.me>

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@diega @Gabriel-Trintinalia
Set PUSH0 as valid opcode for EOF1 validation (hyperledger#4733)
7789a02 
Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com>

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@ahamlat @matkt
@garyschulte @Gabriel-Trintinalia
Ensure that Snashot worldstates remain open for async operations (hyp…
24011e4 
…erledger#4767)

* Fix segfault on async operations on closed snapshot worldstate

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Co-authored-by: matkt <t2am.karim@gmail.com>
Co-authored-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@garyschulte @Gabriel-Trintinalia
prep changelog for 22.10.2 (hyperledger#4769)
ac7d701 
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@garyschulte @Gabriel-Trintinalia
subscribe prior to getting stateTrieNode in cacheStorageNodes (hyperl…
fc0ef37 
…edger#4771)

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
garyschulte and others added 13 commits December 8, 2022 14:32
@garyschulte @Gabriel-Trintinalia
22.10.2 release (hyperledger#4772)
61f24ad 
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@garyschulte @Gabriel-Trintinalia
Prepare for version 22.10.3-SNAPSHOT (hyperledger#4773)
0790474 
* Update version to 22.10.3-SNAPSHOT

Signed-off-by: garyschulte <garyschulte@gmail.com>

* update changelog for 22.10.3

Signed-off-by: garyschulte <garyschulte@gmail.com>

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@mark-terry @macfarla @Gabriel-Trintinalia
Added max range CLI option for eth_getLogs. (hyperledger#4597)
5a478aa 
* Added max range CLI option for eth_getLogs. Default value: 1000.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@mark-terry @Gabriel-Trintinalia
Changed chain download error log level from error to debug. (hyperled…
f68ccd8 
…ger#4775)

Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Fix storage key format for eth_getProof (hyperledger#4564)
5b75066 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Implement eth/68 (EIP-5793) (hyperledger#4730)
30faf53 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@macfarla @NicolasMassart @Gabriel-Trintinalia
Moved besu docs devs to emeritus (hyperledger#4782)
6863726 
* emeritus

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Replace option to choose capabilities with min cap
d4ab327 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@shemnon @Gabriel-Trintinalia
Speedup modexp (hyperledger#4780)
59b3d4b 
Increate the speed of ModExp gas calculations by using primitive types.
Use a native lib for modexp precompile.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* Native modexp

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@jframe @Gabriel-Trintinalia
Add Gabriel Fukushima as a maintainer (hyperledger#4750)
345886b 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Fix spotless
8cfa571 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Remove supportedCapabilities reference and fix unit tests
d4ea08d 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Fix spotlessJava
bbbbfce 
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review December 8, 2022 04:21
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title Hidden option to enforce an eth capability maximum Hidden option to enforce maximum or minimum eth capability Dec 8, 2022
@Gabriel-Trintinalia Gabriel-Trintinalia added the TeamRevenant GH issues worked on by Revenant Team label Dec 8, 2022
@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) December 8, 2022 04:25
macfarla
macfarla reviewed Dec 9, 2022
View reviewed changes
ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/network/NetworkRunner.java Outdated
@@ -78,6 +78,12 @@ public void start() {
LOG.info("Starting Network.");
setupHandlers();
network.start();

LOG.info(
"Max supported protocol: {}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is logging all supported, not just max?

@Gabriel-Trintinalia
Fix log message
5ebaff9 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Change changelog
99bc5f5 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
macfarla approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 72387a5 into hyperledger:main Dec 9, 2022
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the hidden-flag-max-eth-capability branch December 11, 2022 10:57
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 18, 2022
@Gabriel-Trintinalia @ahamlat
Hidden option to enforce maximum or minimum eth capability (hyperledg…
4a57b31 
…er#4752)

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
macfarla pushed a commit to macfarla/besu that referenced this pull request Jan 10, 2023
@Gabriel-Trintinalia @macfarla
Hidden option to enforce maximum or minimum eth capability (hyperledg…
091288e 
…er#4752)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@Gabriel-Trintinalia @eum602
Hidden option to enforce maximum or minimum eth capability (hyperledg…
1d61711 
…er#4752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@matkt matkt Awaiting requested review from matkt

Assignees
No one assigned
Labels
mainnet TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet