Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Networks #4869

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Dec 30, 2022

PR description

Remove the Ropsten, Kiln, Shandong, and Astor network definitions from the built-in network list. Includes tendrils depending on and testing such configurations.

Signed-off-by: Danno Ferrin danno.ferrin@swirldslabs.com

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Remove the Ropsten, Kiln, Shandong, and Astor network definitions from
the built-in network list.  Includes tendrils depending on and testing
such configurations.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon shemnon added the doc-change-required Indicates an issue or PR that requires doc to be updated label Dec 30, 2022
@shemnon
Copy link
Contributor Author

shemnon commented Dec 30, 2022

Required doc change -

Remove the Ropsten, Kiln, Astor, and Shandong networks from the documentation, if they exist and basically anywhere they exist. We may want to consider listing notable public networks whose preconfigured genesis files were removed, probably only Ropsten warrants that handling however. We never supported the morden network, so that may be worth discussing too.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Copy link
Contributor

@diega diega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean up!

Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 👍

@shemnon shemnon merged commit 4508174 into hyperledger:main Jan 2, 2023
@rolandtyler rolandtyler removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jan 5, 2023
macfarla pushed a commit to macfarla/besu that referenced this pull request Jan 10, 2023
Remove the Ropsten, Kiln, Shandong, and Astor network definitions from
the built-in network list.  Includes tendrils depending on and testing
such configurations.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
diega added a commit to diega/besu-docs that referenced this pull request Aug 28, 2023
diega added a commit to diega/besu-docs that referenced this pull request Aug 28, 2023
Removed in [Besu#4869](hyperledger/besu#4869)

Signed-off-by: Diego López León <dieguitoll@gmail.com>
diega added a commit to diega/besu-docs that referenced this pull request Aug 29, 2023
Removed in [Besu#4869](hyperledger/besu#4869)

Signed-off-by: Diego López León <dieguitoll@gmail.com>
alexandratran pushed a commit to hyperledger/besu-docs that referenced this pull request Aug 31, 2023
* Remove Astor network

Removed in [Besu#4869](hyperledger/besu#4869)

Signed-off-by: Diego López León <dieguitoll@gmail.com>

* Remove Kotti network

Removed in [Besu#5816](hyperledger/besu#5816)

Signed-off-by: Diego López León <dieguitoll@gmail.com>

---------

Signed-off-by: Diego López León <dieguitoll@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Remove the Ropsten, Kiln, Shandong, and Astor network definitions from
the built-in network list.  Includes tendrils depending on and testing
such configurations.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants