Remove LowestInvalidNonceCache #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
remove-invalid-nonce-cache
branch
from
f8848c6
to
f82f5d1
Compare
macfarla
approved these changes
Nov 14, 2023
| @@ -19,6 +19,7 @@ | |||
| - Add `yParity` to GraphQL and JSON-RPC for relevant querise. [6119](https://github.com/hyperledger/besu/pull/6119) | |||
| - Force tx replacement price bump to zero when zero base fee market is configured or `--min-gas-price` is set to 0. This allows for easier tx replacement in networks where there is not gas price. [#6079](https://github.com/hyperledger/besu/pull/6079) | |||
| - Introduce the possibility to limit the time spent selecting pending transactions during block creation, using the new experimental option `Xblock-txs-selection-max-time` on PoS and PoW networks (by default set to 5000ms) or `Xpoa-block-txs-selection-max-time` on PoA networks (by default 75% of the min block time) [#6044](https://github.com/hyperledger/besu/pull/6044) | |||
| - Remove LowestInvalidNonceCache from `legacy` transaction pool to make it more private networks friendly [#6148](https://github.com/hyperledger/besu/pull/6148) | |||
There was a problem hiding this comment.
this isn't a breaking change, right? no CLI options or other user config
There was a problem hiding this comment.
correct, not a breaking change.
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 17, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 20, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
LowestInvalidNonceCache was introduce in #4425, as a workaround for avoiding that non executable txs fill the txpool, while we were implementing an better solution to the problem, that become the new layered txpool that is now the default option in Besu, and is tailored for public network.
At this point we can make the simple legacy txpool more private network friendly, and the LowestInvalidNonceCache is usually creating issues these networks, so it makes sense to remove this workaround, since there should be less risk of spammy txs there, and in case users can always switch to layered.
Fixed Issue(s)
fixes #6058