Update to Fix for Feat 1523 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edger-cacti#1534 With this, the `yarn custom-checks` script will go through all the package.json files and validate the following things: 1. The top level "version" property in the package.json of the package is set to a value that equals whatever is set as the project-wide version of the monorepo as defined by the lerna.json file's "version" property. (the latter gets automatically bumped by the relese process) 2. Verifies that all dependencies within each package.json pointing to sibling packages are also using the correct version from lerna.json as described above. 3. Same check as in 2) but for the "devDependencies" section of each package.json file within the monorepo. The upside of this custom check is that maintainers no longer need to manually ensure that the version numbers are kept up to date which was especially tricky when a new package is being added in a pull request that has been open for a while and we issued one or more releases during the lifetime of the pull request. Fixes hyperledger-cacti#1534 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
petermetz
force-pushed
the
feat-1523-rama
branch
from
3a5f18d
to
7ca45d0
Compare
…cti#1523 Adding the .proto definitions from here as discussed earlier with @VRamakrishna To-do: I skipped the fabric driver proto due to an error on account of the Fabric peer definitions not being present (unresolved import error). Fixes hyperledger-cacti#1523 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
…edger-cacti#1523 Updated Weaver protos README and imported latest schema additions Fixes hyperledger-cacti#1523 Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
petermetz
force-pushed
the
feat-1523-rama
branch
from
7ca45d0
to
2949140
Compare
added a dummy package for tests about install packages from github sources required for hyperledger-cacti#1210 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
…ll them Added parameter action to PluginImport to determine if the plugin should be installed. Enabled feature to instantiate plugins from cactus-cmd-api-server without install it. Enabled feature to install packages from github Added method create in class ConfigService to override old configuration. Method newExampleConfigConvict accepts a boolean parameter to force configuration override. Closes hyperledger-cacti#1210 Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
|
@VRamakrishna I included this commit in the PR against the main repo (sending a PR against my fork wouldn't work because then I'd still need to PR it up to the upstream anyway so closing this one in favor of the other one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hyperledger-cacti#1523
Signed-off-by: VRamakrishna vramakr2@in.ibm.com