-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421 #3005
build(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421 #3005
Conversation
dd13478
to
779a061
Compare
57dca71
to
ff2219b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez same comment as the other PR. Please update your PR description and commit message to an appropriate one.
0f3e50b
to
2246097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez I recommend this as the commit message (I just renamed the issue to the same) then it has the maximum information and also does not diverge from the issue title and the conventions are satisfied AFAICT.
tools(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421
fe37207
to
145eb61
Compare
Hello @jagpreetsinghsasan already fixed it, thank you. Updated it also with the commit message that Peter has mentioned |
145eb61
to
8536cec
Compare
8536cec
to
5575ab4
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez Very sorry, I must've been very tired when I typed out that recommended commit message because it is also invalid...
Please try this instead: build(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421
5575ab4
to
60ad838
Compare
@petermetz No worries, Already updated it and re requested for review. Thank you |
60ad838
to
6953286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez LGTM thank you and sorry for the slow review on this one!
6953286
to
79f30fd
Compare
@jagpreetsinghsasan Were your change requests addressed to your satisfaction? |
Yes @petermetz , I have resolved those review comments. Its good to merge |
@jagpreetsinghsasan Got it, thank you for confirming! I'll dismiss the review then. |
Confirmed with Jagpreet that issue was addressed.
Primary Changes ---------------- 1. Updated the version of the base image that is used in the Dockerfile 2. Updated the Dockerfile to use the yarn version 4 3. Updated the README to the new command to run the container Fixes hyperledger-cacti#2745 Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
79f30fd
to
9888975
Compare
Commit to be reviewed
build(connector-besu): fix CVE-2022-21190 CVE-2023-36665 CVE-2022-2421
Fixes #2745
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.