Due to improper type validation in the socket.io-parser
library (which is used by the socket.io
and socket.io-client
packages to encode and decode Socket.IO packets), it is possible to overwrite the _placeholder object which allows an attacker to place references to functions at arbitrary places in the resulting query object.
Example:
const decoder = new Decoder();
decoder.on("decoded", (packet) => {
console.log(packet.data); // prints [ 'hello', [Function: splice] ]
})
decoder.add('51-["hello",{"_placeholder":true,"num":"splice"}]');
decoder.add(Buffer.from("world"));
This bubbles up in the socket.io
package:
io.on("connection", (socket) => {
socket.on("hello", (val) => {
// here, "val" could be a function instead of a buffer
});
});
⚠️ IMPORTANT NOTE ⚠️
You need to make sure that the payload that you received from the client is actually a Buffer
object:
io.on("connection", (socket) => {
socket.on("hello", (val) => {
if (!Buffer.isBuffer(val)) {
socket.disconnect();
return;
}
// ...
});
});
If that's already the case, then you are not impacted by this issue, and there is no way an attacker could make your server crash (or escalate privileges, ...).
Example of values that could be sent by a malicious user:
- a number that is out of bounds
Sample packet: 451-["hello",{"_placeholder":true,"num":10}]
io.on("connection", (socket) => {
socket.on("hello", (val) => {
// val is `undefined`
});
});
- a value that is not a number, like
undefined
Sample packet: 451-["hello",{"_placeholder":true,"num":undefined}]
io.on("connection", (socket) => {
socket.on("hello", (val) => {
// val is `undefined`
});
});
- a string that is part of the prototype of
Array
, like "push"
Sample packet: 451-["hello",{"_placeholder":true,"num":"push"}]
io.on("connection", (socket) => {
socket.on("hello", (val) => {
// val is a reference to the "push" function
});
});
- a string that is part of the prototype of
Object
, like "hasOwnProperty"
Sample packet: 451-["hello",{"_placeholder":true,"num":"hasOwnProperty"}]
io.on("connection", (socket) => {
socket.on("hello", (val) => {
// val is a reference to the "hasOwnProperty" function
});
});
This should be fixed by:
Dependency analysis for the socket.io
package
socket.io version |
socket.io-parser version |
Covered? |
4.5.2...latest |
~4.2.0 (ref) |
Yes ✔️ |
4.1.3...4.5.1 |
~4.0.4 (ref) |
Yes ✔️ |
3.0.5...4.1.2 |
~4.0.3 (ref) |
Yes ✔️ |
3.0.0...3.0.4 |
~4.0.1 (ref) |
Yes ✔️ |
2.3.0...2.5.0 |
~3.4.0 (ref) |
Yes ✔️ |
Dependency analysis for the socket.io-client
package
socket.io-client version |
socket.io-parser version |
Covered? |
4.5.0...latest |
~4.2.0 (ref) |
Yes ✔️ |
4.3.0...4.4.1 |
~4.1.1 (ref) |
No, but the impact is very limited |
3.1.0...4.2.0 |
~4.0.4 (ref) |
Yes ✔️ |
3.0.5 |
~4.0.3 (ref) |
Yes ✔️ |
3.0.0...3.0.4 |
~4.0.1 (ref) |
Yes ✔️ |
2.2.0...2.5.0 |
~3.3.0 (ref) |
Yes ✔️ |
References
Due to improper type validation in the
socket.io-parser
library (which is used by thesocket.io
andsocket.io-client
packages to encode and decode Socket.IO packets), it is possible to overwrite the _placeholder object which allows an attacker to place references to functions at arbitrary places in the resulting query object.Example:
This bubbles up in the
socket.io
package:You need to make sure that the payload that you received from the client is actually a
Buffer
object:If that's already the case, then you are not impacted by this issue, and there is no way an attacker could make your server crash (or escalate privileges, ...).
Example of values that could be sent by a malicious user:
Sample packet:
451-["hello",{"_placeholder":true,"num":10}]
undefined
Sample packet:
451-["hello",{"_placeholder":true,"num":undefined}]
Array
, like "push"Sample packet:
451-["hello",{"_placeholder":true,"num":"push"}]
Object
, like "hasOwnProperty"Sample packet:
451-["hello",{"_placeholder":true,"num":"hasOwnProperty"}]
This should be fixed by:
socket.io-parser@4.2.1
socket.io-parser@4.0.5
socket.io-parser@3.4.2
socket.io-parser@3.3.3
Dependency analysis for the
socket.io
packagesocket.io
versionsocket.io-parser
version4.5.2...latest
~4.2.0
(ref)4.1.3...4.5.1
~4.0.4
(ref)3.0.5...4.1.2
~4.0.3
(ref)3.0.0...3.0.4
~4.0.1
(ref)2.3.0...2.5.0
~3.4.0
(ref)Dependency analysis for the
socket.io-client
packagesocket.io-client
versionsocket.io-parser
version4.5.0...latest
~4.2.0
(ref)4.3.0...4.4.1
~4.1.1
(ref)3.1.0...4.2.0
~4.0.4
(ref)3.0.5
~4.0.3
(ref)3.0.0...3.0.4
~4.0.1
(ref)2.2.0...2.5.0
~3.3.0
(ref)References