Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix VSCode dev container publish job - use official builder #3316

Merged

Conversation

petermetz
Copy link
Contributor

  1. We don't have a Dockerfile anymore to define the image of the dev container
    instead the build's input is the devcontainer.json file which can be built
    using the @devcontainers/cli npm package instead of the usual docker build
    command on the terminal.
  2. The ci.yaml job building the image was already doing the build this way but
    we must've forgotten to update the publish job as well.

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. We don't have a Dockerfile anymore to define the image of the dev container
instead the build's input is the `devcontainer.json` file which can be built
using the `@devcontainers/cli` npm package instead of the usual `docker build`
command on the terminal.
2. The ci.yaml job building the image was already doing the build this way but
we must've forgotten to update the publish job as well.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the ci-fix-devcontainer-publish-ci-job branch from 71ee79c to df2b722 Compare June 14, 2024 14:37
@petermetz petermetz merged commit e680730 into hyperledger-cacti:main Jun 14, 2024
144 of 149 checks passed
@petermetz petermetz deleted the ci-fix-devcontainer-publish-ci-job branch June 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants