Skip to content

Commit 78e4e84

Browse files
authored
Remove channel and chaincode ops from Fabric v1 (#1411)
Signed-off-by: CaptainIRS <36656347+CaptainIRS@users.noreply.github.com>
1 parent 5025d20 commit 78e4e84

File tree

7 files changed

+3
-925
lines changed

7 files changed

+3
-925
lines changed

packages/caliper-fabric/lib/connector-versions/v1/FabricChaincodeOperations.js

Lines changed: 0 additions & 490 deletions
This file was deleted.

packages/caliper-fabric/lib/connector-versions/v1/FabricChannelOperations.js

Lines changed: 0 additions & 401 deletions
This file was deleted.

packages/caliper-fabric/lib/connector-versions/v1/FabricGateway.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ const semver = require('semver');
1717
const { DefaultEventHandlerStrategies, DefaultQueryHandlerStrategies, Gateway } = require('fabric-network');
1818
const { ConnectorBase, CaliperUtils, TxStatus, ConfigUtil } = require('@hyperledger/caliper-core');
1919
const FabricConnectorContext = require('../../FabricConnectorContext');
20-
const FabricChannelOperations = require('./FabricChannelOperations');
21-
const FabricChaincodeOperations = require('./FabricChaincodeOperations');
2220

2321
const logger = CaliperUtils.getLogger('connectors/v1/FabricGateway');
2422

@@ -133,18 +131,14 @@ class V1FabricGateway extends ConnectorBase {
133131
const tlsInfo = this.connectorConfiguration.isMutualTLS() ? 'mutual'
134132
: ((await this.connectorConfiguration.getConnectionProfileDefinitionForOrganization(defaultOrganization)).isTLSEnabled() ? 'server' : 'none');
135133
logger.info(`Fabric SDK version: ${this.fabricNetworkVersion.toString()}; TLS based on ${defaultOrganization}: ${tlsInfo}`);
136-
137-
const fabricChannelOperations = new FabricChannelOperations(this.connectorConfiguration);
138-
await fabricChannelOperations.createChannelsAndJoinPeers();
139134
}
140135

141136
/**
142137
* Installs and initializes the specified contracts.
143138
* @async
144139
*/
145140
async installSmartContract() {
146-
const fabricChaincodeOperations = new FabricChaincodeOperations(this.connectorConfiguration);
147-
await fabricChaincodeOperations.installAndInstantiateChaincodes();
141+
logger.warn(`Install smart contract not available with Fabric SDK version: ${this.fabricNetworkVersion.toString()}`);
148142
}
149143

150144
/**

packages/caliper-fabric/lib/connector-versions/v1/FabricNonGateway.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ const FabricConstants = require('fabric-client/lib/Constants');
1818
const {ConnectorBase, CaliperUtils, TxStatus, Version, ConfigUtil} = require('@hyperledger/caliper-core');
1919
const FabricConnectorContext = require('../../FabricConnectorContext');
2020
const ClientCreator = require('./ClientCreator');
21-
const FabricChannelOperations = require('./FabricChannelOperations');
22-
const FabricChaincodeOperations = require('./FabricChaincodeOperations');
2321
const logger = CaliperUtils.getLogger('connectors/v1/FabricNonGateway');
2422

2523
/**
@@ -129,18 +127,14 @@ class V1Fabric extends ConnectorBase {
129127
const tlsInfo = this.connectorConfiguration.isMutualTLS() ? 'mutual'
130128
: ((await this.connectorConfiguration.getConnectionProfileDefinitionForOrganization(defaultOrganization)).isTLSEnabled() ? 'server' : 'none');
131129
logger.info(`Fabric SDK version: ${this.fabricNetworkVersion.toString()}; TLS based on ${defaultOrganization}: ${tlsInfo}`);
132-
133-
const fabricChannelOperations = new FabricChannelOperations(this.connectorConfiguration);
134-
await fabricChannelOperations.createChannelsAndJoinPeers();
135130
}
136131

137132
/**
138133
* Installs and initializes the specified contracts.
139134
* @async
140135
*/
141136
async installSmartContract() {
142-
const fabricChaincodeOperations = new FabricChaincodeOperations(this.connectorConfiguration);
143-
await fabricChaincodeOperations.installAndInstantiateChaincodes();
137+
logger.warn(`Install smart contract not available with Fabric SDK version: ${this.fabricNetworkVersion.toString()}`);
144138
}
145139

146140
/**

packages/caliper-fabric/package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"semver": "7.1.1"
2828
},
2929
"devDependencies": {
30-
"fabric-protos": "2.1.0",
3130
"chai": "^3.5.0",
3231
"chai-as-promised": "^7.1.1",
3332
"eslint": "^5.16.0",
@@ -88,8 +87,6 @@
8887
"lib/identity-management/IWallet*",
8988
"lib/connector-versions/v1/fabric-gateway.js",
9089
"lib/connector-versions/v1/fabric.js",
91-
"lib/connector-versions/v1/FabricChaincodeOperations.js",
92-
"lib/connector-versions/v1/FabricChannelOperations.js",
9390
"lib/connector-versions/v2/fabric-gateway.js",
9491
"lib/connector-versions/v2/registrarHelper.js"
9592
],
@@ -105,4 +102,4 @@
105102
"lines": 1
106103
},
107104
"license": "Apache-2.0"
108-
}
105+
}

packages/caliper-fabric/test/connector-versions/v1/FabricGateway.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,6 @@ describe('A Node-SDK V1 Fabric Gateway', () => {
5757
mockery.registerMock('fabric-client', Client);
5858
mockery.registerMock('fabric-client/lib/Constants', Constants);
5959
mockery.registerMock('fabric-network/package', {version: '1.4.11'});
60-
mockery.registerMock('./FabricChannelOperations', class {
61-
/** */
62-
async createChannelsAndJoinPeers() {}
63-
});
64-
mockery.registerMock('./FabricChaincodeOperations', class {
65-
/** */
66-
async installAndInstantiateChaincodes() {}
67-
});
6860

6961
FabricGateway = require('../../../lib/connector-versions/v1/FabricGateway');
7062
GenerateWallet = require('../../utils/GenerateWallet');

packages/caliper-fabric/test/connector-versions/v1/FabricNonGateway.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,6 @@ describe('A Node-SDK V1 Fabric Non Gateway', () => {
4646
mockery.registerMock('fabric-client', Client);
4747
mockery.registerMock('fabric-client/lib/Constants', Constants);
4848
mockery.registerMock('fabric-client/package', {version: '1.4.11'});
49-
mockery.registerMock('./FabricChannelOperations', class {
50-
/** */
51-
async createChannelsAndJoinPeers() {}
52-
});
53-
mockery.registerMock('./FabricChaincodeOperations', class {
54-
/** */
55-
async installAndInstantiateChaincodes() {}
56-
});
5749

5850
FabricNonGateway = require('../../../lib/connector-versions/v1/FabricNonGateway');
5951
FabricConnectorContext = require('../../../lib/FabricConnectorContext');

0 commit comments

Comments
 (0)