Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to enable go lint with options #117

Closed
SamYuan1990 opened this issue Apr 16, 2023 · 4 comments · Fixed by #201
Closed

Try to enable go lint with options #117

SamYuan1990 opened this issue Apr 16, 2023 · 4 comments · Fixed by #201
Assignees
@channingduan @SamYuan1990
Labels
stale

Comments

@SamYuan1990
Copy link
Contributor

SamYuan1990 commented Apr 16, 2023 •
edited
Loading 

#- varcheck
  #- gocyclo
  #- bodyclose
  #- misspell
  #- nakedret
  #- unconvert
  # - goconst
  # - gocritic
  # - noctx
  # - whitespace
  # - dupl

to improve our code quantity with lint options above.
@SamYuan1990
Copy link
Contributor Author

@channingduan , could you please take a look at this issue?

@SamYuan1990 SamYuan1990 mentioned this issue Apr 16, 2023
Closed
@bestbeforetoday
Copy link
Member

Just for reference, the current set of linters being run (in addition to staticcheck) are:

  • errcheck
  • gofmt
  • goimports
  • gosec
  • gosimple
  • govet
  • ineffassign
  • typecheck
  • unused

The active linters are configured in .golangci.yml. See the golangci-lint documentation for available linters.

@SamYuan1990
Copy link
Contributor Author

Just for reference, the current set of linters being run (in addition to staticcheck) are:

  • errcheck
  • gofmt
  • goimports
  • gosec
  • gosimple
  • govet
  • ineffassign
  • typecheck
  • unused

The active linters are configured in .golangci.yml. See the golangci-lint documentation for available linters.

thanks a lot for comments, updated scope.

@stale
Copy link

stale bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 8, 2023
@bestbeforetoday bestbeforetoday mentioned this issue Sep 17, 2024
Merged
bestbeforetoday added a commit that referenced this issue Sep 18, 2024
@bestbeforetoday
Additional Go linting (#201)
b61ba94 
Some cyclomatic or cognitive complexity failures are suppressed since
they are in existing code - some of which is lifted from Fabric
internals - and not trivially fixed as part of this change.

Closes #117

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@channingduan channingduan

@SamYuan1990 SamYuan1990

Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Additional Go linting bestbeforetoday/fabric-admin-sdk
3 participants
@channingduan @bestbeforetoday @SamYuan1990