Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in publish of built binaries #241

Closed
wants to merge 2 commits into from

Conversation

mbwhite
Copy link
Member

@mbwhite mbwhite commented Aug 13, 2021

Signed-off-by: Matthew B White whitemat@uk.ibm.com

Type of change

  • Bug fix
  • New feature
  • Improvement (improvement to code, performance, etc)
  • Test update
  • Documentation update

Description

Additional details

Related issues

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
@mbwhite mbwhite requested a review from a team as a code owner August 13, 2021 10:21
@denyeart
Copy link
Contributor

@mbwhite Could you update PR description with the motivation? Is this just so that we can pull down the built images to try them out?

Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
Copy link
Contributor

@mastersingh24 mastersingh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description / comment to explain exactly what you are doing and why

@lindluni
Copy link
Contributor

Please update the PR description / comment to explain exactly what you are doing and why

I'm pretty sure I fixed what was attempting to be fixed here in: #243

@denyeart
Copy link
Contributor

denyeart commented Oct 7, 2021

Agree with lindluni, closing.

@denyeart denyeart closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants