Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chaincode dev sample #314

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Conversation

nikhil550
Copy link
Contributor

The Chaincode dev mode sample in the Fabric samples has not been updated for 2.x and does not work on master.

Rather maintaining a sample, I propose that it would be better to tell people how to use chaincode in dev mode through documentation alone. This documentation is being added with this PR: hyperledger/fabric#1704. This sample can now be removed.

Signed-off-by: NIKHIL E GUPTA negupta@us.ibm.com

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>
@nikhil550 nikhil550 marked this pull request as ready for review August 28, 2020 14:39
@nikhil550 nikhil550 requested a review from a team as a code owner August 28, 2020 14:39
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lehors lehors merged commit 5b7f2fc into hyperledger:master Sep 15, 2020
@nikhil550 nikhil550 deleted the delDevMode branch September 15, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants