Skip to content

Commit 2cac010

Browse files
committed
[FAB-15267] Refactor goGen in discovery/cmd
Refactoring go:generate in /fabric/discovery/cmd, create local interfaces to generate mocks for tests. Change-Id: I4578b29a6d3086d9a505c7cc967359b7890e388c Signed-off-by: Chongxin Luo <Chongxin.Luo@ibm.com>
1 parent 2e4e520 commit 2cac010

File tree

7 files changed

+35
-16
lines changed

7 files changed

+35
-16
lines changed

discovery/cmd/mocks/channel_response.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/cmd/mocks/command_registrar.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/cmd/mocks/local_response.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/cmd/mocks/response_parser.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/cmd/mocks/service_response.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/cmd/mocks/stub.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

discovery/cmd/stub.go

Lines changed: 28 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,34 +12,46 @@ import (
1212
"github.com/hyperledger/fabric/cmd/common"
1313
"github.com/hyperledger/fabric/cmd/common/comm"
1414
"github.com/hyperledger/fabric/cmd/common/signer"
15-
discovery "github.com/hyperledger/fabric/discovery/client"
16-
. "github.com/hyperledger/fabric/protos/discovery"
15+
discoveryclient "github.com/hyperledger/fabric/discovery/client"
16+
"github.com/hyperledger/fabric/protos/discovery"
1717
"github.com/hyperledger/fabric/protoutil"
1818
"github.com/pkg/errors"
1919
)
2020

21-
//go:generate mockery -dir ../client/ -name LocalResponse -case underscore -output mocks/
22-
//go:generate mockery -dir ../client/ -name ChannelResponse -case underscore -output mocks/
21+
//go:generate mockery -dir . -name LocalResponse -case underscore -output mocks/
22+
23+
// LocalResponse is the local interface used to generate mocks for foreign interface.
24+
type LocalResponse interface {
25+
discoveryclient.LocalResponse
26+
}
27+
28+
//go:generate mockery -dir . -name ChannelResponse -case underscore -output mocks/
29+
30+
// ChannelResponse is the local interface used to generate mocks for foreign interface.
31+
type ChannelResponse interface {
32+
discoveryclient.ChannelResponse
33+
}
34+
2335
//go:generate mockery -dir . -name ServiceResponse -case underscore -output mocks/
2436

2537
// ServiceResponse represents a response sent from the discovery service
2638
type ServiceResponse interface {
2739
// ForChannel returns a ChannelResponse in the context of a given channel
28-
ForChannel(string) discovery.ChannelResponse
40+
ForChannel(string) discoveryclient.ChannelResponse
2941

3042
// ForLocal returns a LocalResponse in the context of no channel
31-
ForLocal() discovery.LocalResponse
43+
ForLocal() discoveryclient.LocalResponse
3244

3345
// Raw returns the raw response from the server
34-
Raw() *Response
46+
Raw() *discovery.Response
3547
}
3648

3749
type response struct {
38-
raw *Response
39-
discovery.Response
50+
raw *discovery.Response
51+
discoveryclient.Response
4052
}
4153

42-
func (r *response) Raw() *Response {
54+
func (r *response) Raw() *discovery.Response {
4355
return r.raw
4456
}
4557

@@ -49,7 +61,7 @@ type ClientStub struct {
4961
}
5062

5163
// Send sends the request, and receives a response
52-
func (stub *ClientStub) Send(server string, conf common.Config, req *discovery.Request) (ServiceResponse, error) {
64+
func (stub *ClientStub) Send(server string, conf common.Config, req *discoveryclient.Request) (ServiceResponse, error) {
5365
comm, err := comm.NewClient(conf.TLSConfig)
5466
if err != nil {
5567
return nil, err
@@ -61,9 +73,9 @@ func (stub *ClientStub) Send(server string, conf common.Config, req *discovery.R
6173
timeout, cancel := context.WithTimeout(context.Background(), defaultTimeout)
6274
defer cancel()
6375

64-
disc := discovery.NewClient(comm.NewDialer(server), signer.Sign, 0)
76+
disc := discoveryclient.NewClient(comm.NewDialer(server), signer.Sign, 0)
6577

66-
resp, err := disc.Send(timeout, req, &AuthInfo{
78+
resp, err := disc.Send(timeout, req, &discovery.AuthInfo{
6779
ClientIdentity: signer.Creator,
6880
ClientTlsCertHash: comm.TLSCertHash,
6981
})
@@ -81,7 +93,7 @@ type RawStub struct {
8193
}
8294

8395
// Send sends the request, and receives a response
84-
func (stub *RawStub) Send(server string, conf common.Config, req *discovery.Request) (ServiceResponse, error) {
96+
func (stub *RawStub) Send(server string, conf common.Config, req *discoveryclient.Request) (ServiceResponse, error) {
8597
comm, err := comm.NewClient(conf.TLSConfig)
8698
if err != nil {
8799
return nil, err
@@ -93,7 +105,7 @@ func (stub *RawStub) Send(server string, conf common.Config, req *discovery.Requ
93105
timeout, cancel := context.WithTimeout(context.Background(), defaultTimeout)
94106
defer cancel()
95107

96-
req.Authentication = &AuthInfo{
108+
req.Authentication = &discovery.AuthInfo{
97109
ClientIdentity: signer.Creator,
98110
ClientTlsCertHash: comm.TLSCertHash,
99111
}
@@ -108,7 +120,7 @@ func (stub *RawStub) Send(server string, conf common.Config, req *discovery.Requ
108120
if err != nil {
109121
return nil, err
110122
}
111-
resp, err := NewDiscoveryClient(cc).Discover(timeout, &SignedRequest{
123+
resp, err := discovery.NewDiscoveryClient(cc).Discover(timeout, &discovery.SignedRequest{
112124
Payload: payload,
113125
Signature: sig,
114126
})

0 commit comments

Comments
 (0)