FAB-18070 Ch.Part.API: refactor to avoid support pattern #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using the "support" pattern with the follower. That is, do not pass a monolithic structure that embeds all the dependencies of the follower. Instead, pass dependencies as concrete types that implement individual interfaces that the follower needs. Some methods that are needed by both the follower and consensus.Chains are promoted from `ChainSupport` to `ledgerResources` along with respective tests. Signed-off-by: Yoav Tock <tock@il.ibm.com> Change-Id: I09e49951ce60e897b08499ef7ef1bf2a4652f834
jyellick
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using the "support" pattern with the follower.
That is, do not pass a monolithic structure that embeds all
the dependencies of the follower. Instead, pass dependencies
as concrete types that implement individual interfaces that
the follower needs.
Some methods that are needed by both the follower and
consensus.Chains are promoted from
ChainSupporttoledgerResourcesalong with respective tests.Signed-off-by: Yoav Tock tock@il.ibm.com
Change-Id: I09e49951ce60e897b08499ef7ef1bf2a4652f834
Type of change
Related issues
Task: FAB-18070
Epic: FAB-17712