FAB-17161 improve error message #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp-run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ale-linux
previously requested changes
Nov 27, 2019
Combination of OUs is not allowed, where error message returned contains address of OU object, which is not human friendly. This commit changes it to print actual OU identifiers in []string. Test done: use disallowed combination of OUs for a Fabric network and observe error message returned to contain clear text. Change-Id: Ie7fd19e6542b7b78a736e5b4b6092ad637e37152 Signed-off-by: Jay Guo <guojiannan1101@gmail.com>
guoger
force-pushed
the
err-msg-improvement
branch
from
945b0f3
to
7a309c7
Compare
guoger
requested review from
binhn,
C0rWin,
christo4ferris,
denyeart,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini,
sykesm and
yacovm
as code owners
ale-linux
approved these changes
Dec 2, 2019
kchristidis
approved these changes
Dec 2, 2019
|
@Mergifyio backport release-1.4 |
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of OUs is not allowed, where error message returned
contains address of OU object, which is not human friendly. This
commit changes it to print actual OU identifiers in []string.
Test done: use disallowed combination of OUs for a Fabric network
and observe error message returned to contain clear text.
Change-Id: Ie7fd19e6542b7b78a736e5b4b6092ad637e37152
Signed-off-by: Jay Guo guojiannan1101@gmail.com