-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up go 1.22.4 #4884
up go 1.22.4 #4884
Conversation
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/hyperledger/fabric | |||
|
|||
go 1.22 | |||
go 1.22.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the 2 digit version here. Every other go.mod file I've seen uses the 2 digit version since new features are only introduced in major.minor releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that.
But, I did so according to the changes in the documentation, since go version 1.21. At least that's how I understood the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for the links. I still think we should keep it at major.minor (e.g. 1.22). We have the option to include the patch version here (e.g. 1.22.4), but my opinion is that we should do that only if the patch becomes important, that is, if Fabric depends on some behavior of the patch. Since Fabric continues to work with any 1.22.x version, I think 1.22 continues to be correct here.
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
@denyeart please, run manual actions vulnerability-scan |
No description provided.